Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the tracker file writing asynchronous for performance #14

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

mkorbel1
Copy link
Contributor

@mkorbel1 mkorbel1 commented Aug 19, 2022

Description & Motivation

Writing to files synchronously can cause performance issues on the main program thread. Writing asynchronously with the tracker can improve test run time.

Related Issue(s)

Fix #12

Testing

Existing test covers it.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No, but Tracker.terminate is now asynchronous so if it was not safely awaited before it could reveal a new issue in usage.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

@mkorbel1 mkorbel1 merged commit f6b0383 into intel:main Aug 19, 2022
@mkorbel1 mkorbel1 deleted the asynctracker branch August 19, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve performance of tracker writing using async methods
1 participant