Add improved checks and behavior for memory with invalid values #268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
There were some concerns (e.g. intel/rohd#634) that things like the
RegisterFilecould have improper, overly optimistic behavior when invalid values were present on the write ports.This PR:
Memorys includingRegisterFileandMemoryModelMemoryModelMemoryModeldefault behavior to prefer theTest.intance.logger, if available, instead ofprint.Related Issue(s)
intel/rohd#634 (unable to reproduce)
Testing
Added more tests
Backwards-compatibility
No, though
MemoryModelis now slightly less pessimisticDocumentation
No