Skip to content
This repository was archived by the owner on Oct 22, 2024. It is now read-only.
This repository was archived by the owner on Oct 22, 2024. It is now read-only.

DeleteVolume response is incorrect if volume is in use #402

Closed
@okartau

Description

@okartau

CSI spec says that if a volume is in use, DeleteVolume response should be error=FAILED_PRECONDITION.
Currently, PMEM-CSI responds with codes.InternalError in all cases when lower layer (Device) returns any error, although the BUSY status is detected and is one of the reasons to fail.
To make the GRPC error correct, we have to start returning more detailed error codes by cs.dm.DeleteDevice and form a RPC return code correctly if volume/device was in-use.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions