Don't pass outdated -D__undef_<feature> flags to clang #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flags were removed in llvm/llvm-project@423bdb2b
There was a problem hiding this comment.
Pull request overview
This PR removes outdated compiler flags that are no longer supported by clang. The removed code was passing -D__undef_<feature> flags to undefine optional OpenCL C core features, but these flags were removed from LLVM in commit 423bdb2b.
Key Changes:
- Removed logic that generated
-D__undef_<feature>flags for optional OpenCL C core features - Cleaned up associated code including the feature list array and iteration logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cdai2
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flags were removed in llvm/llvm-project@423bdb2b