Skip to content

Properly pass no-opaque-pointers to spirv translator #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions opencl_clang.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ Compile(const char *pszProgramSource, const char **pInputHeaders,
pResult->GetIRSize());
std::unique_ptr<llvm::MemoryBuffer> MB = llvm::MemoryBuffer::getMemBuffer(LLVM_IR, pResult->GetIRName(), false);
llvm::LLVMContext Context;
Context.setOpaquePointers(optionsParser.hasOpaquePointers());
auto E = llvm::getOwningLazyBitcodeModule(std::move(MB), Context,
/*ShouldLazyLoadMetadata=*/true);
llvm::logAllUnhandledErrors(E.takeError(), err_ostream, "error: ");
Expand Down
4 changes: 3 additions & 1 deletion options.h
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ class EffectiveOptionsFilter {
class CompileOptionsParser {
public:
CompileOptionsParser(const char *pszOpenCLVersion)
: m_commonFilter(pszOpenCLVersion), m_emitSPIRV(false), m_optDisable(false) {}
: m_commonFilter(pszOpenCLVersion), m_emitSPIRV(false), m_optDisable(false), m_opaquePointers(true) {}

//
// Validates and prepares the effective options to pass to clang upon
Expand Down Expand Up @@ -178,6 +178,7 @@ class CompileOptionsParser {

bool hasEmitSPIRV() const { return m_emitSPIRV; }
bool hasOptDisable() const { return m_optDisable; }
bool hasOpaquePointers() const { return m_opaquePointers; }

private:
OpenCLCompileOptTable m_optTbl;
Expand All @@ -187,6 +188,7 @@ class CompileOptionsParser {
std::string m_sourceName;
bool m_emitSPIRV;
bool m_optDisable;
bool m_opaquePointers;
};

// Tokenize a string into tokens separated by any char in 'delims'.
Expand Down
3 changes: 3 additions & 0 deletions options_compile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,9 @@ void CompileOptionsParser::processOptions(const char *pszOptions,
m_emitSPIRV = true;
continue;
}
else if (it->compare("-no-opaque-pointers") == 0) {
m_opaquePointers = false;
}
m_effectiveArgsRaw.push_back(it->c_str());
}
}
Expand Down