-
Notifications
You must be signed in to change notification settings - Fork 39
Sahar/tdr failure #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sahar/tdr failure #698
Conversation
@MayureshV1 please review |
ca91927
to
fd6bcac
Compare
@@ -294,12 +262,16 @@ void OVInferRequest::Infer() { | |||
} | |||
|
|||
void OVInferRequest::WaitRequest() { | |||
ovInfReq.wait(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have an exception handling for waitRequest as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -459,150 +439,46 @@ void BasicBackend::StartAsyncInference(Ort::KernelContext& context, OVInferReque | |||
} | |||
} | |||
|
|||
#ifdef IO_BUFFER_ENABLED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfatimar . Why is IO Buffer Optimization removed ?
Description
Handle Exceptions in Parallel Execution with OpenVINO Execution Provider
Motivation and Context
Once a TDR Occurs a Inference request must be cancelled and removed from queue
Perf test was experiencing a race condition as lock mutex was not out of same thread pool