Skip to content

Conversation

@mengniwang95
Copy link
Contributor

@mengniwang95 mengniwang95 commented Dec 8, 2025

User description

Update scout setup.sh


PR Type

Enhancement


Description

  • Update setup.sh to clone different branch

  • Use --editable for pip install


Diagram Walkthrough

flowchart LR
  A["Clone mxfp4 branch"] -- "Updated to" --> B["Clone fused-moe-ar branch"]
  C["Non-editable install"] -- "Updated to" --> D["Editable install"]
Loading

File Walkthrough

Relevant files
Enhancement
setup.sh
Update git clone and pip install commands                               

examples/pytorch/multimodal-modeling/quantization/auto_round/llama4/setup.sh

  • Updated git clone command to target fused-moe-ar branch
  • Added --single-branch and --quiet flags to git clone
  • Changed pip install command to use --editable
+2/-4     

@PRAgent4INC
Copy link
Collaborator

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Branch Change

The branch being cloned has been changed from mxfp4 to fused-moe-ar. Ensure that this new branch is stable and compatible with the rest of the setup.

git clone -b fused-moe-ar --single-branch --quiet https://github.com/yiliu30/vllm-fork.git && cd vllm-fork
Editable Install

The installation method has been changed to editable mode using --editable. Verify that this change does not introduce any issues with package dependencies or build processes.

VLLM_USE_PRECOMPILED=1 pip install --editable . -vvv

@PRAgent4INC
Copy link
Collaborator

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Add error handling for git and pip commands

Ensure that the cd command is successful before proceeding with the pip install.
Add
error handling to manage potential failures during cloning or installation.

examples/pytorch/multimodal-modeling/quantization/auto_round/llama4/setup.sh [5-6]

-git clone -b fused-moe-ar --single-branch --quiet https://github.com/yiliu30/vllm-fork.git && cd vllm-fork
-VLLM_USE_PRECOMPILED=1 pip install --editable . -vvv
+git clone -b fused-moe-ar --single-branch --quiet https://github.com/yiliu30/vllm-fork.git && \
+cd vllm-fork || { echo "Failed to clone or enter vllm-fork directory"; exit 1; } && \
+VLLM_USE_PRECOMPILED=1 pip install --editable . -vvv || { echo "Failed to install vllm-fork"; exit 1; }
Suggestion importance[1-10]: 7

__

Why: The suggestion adds error handling to ensure that the script exits with an appropriate message if the git clone or pip install commands fail. This improves the robustness of the setup script.

Medium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants