Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix woq example and update document for v1.19.0 #2097

Merged
merged 6 commits into from
Dec 25, 2024
Merged

fix woq example and update document for v1.19.0 #2097

merged 6 commits into from
Dec 25, 2024

Conversation

xin3he
Copy link
Contributor

@xin3he xin3he commented Dec 23, 2024

Type of Change

feature or bug fix or documentation or validation or others
API changed or not

Description

detail description

Expected Behavior & Potential Risk

the expected behavior that triggered by this PR

How has this PR been tested?

how to reproduce the test (including hardware information)

Dependency Change?

any library dependency introduced or removed

Copy link
Contributor

@thuang6 thuang6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: xin3he <xin3.he@intel.com>
@XuehaoSun XuehaoSun added this to the 3.2 milestone Dec 23, 2024
@xin3he
Copy link
Contributor Author

xin3he commented Dec 24, 2024

image
it's a fix for accuracy, bf16 cannot get correct accuracy as below, no idea but bf16 is not necessary so remove it.
inc_gaudi_test #150 [Jenkins]

Signed-off-by: Xin He <xinhe3@habana.ai>
Signed-off-by: Xin He <xinhe3@habana.ai>
@xin3he
Copy link
Contributor Author

xin3he commented Dec 24, 2024

Signed-off-by: Xin He <xinhe3@habana.ai>
@xin3he
Copy link
Contributor Author

xin3he commented Dec 24, 2024

@XuehaoSun please help trigger the test of opt_125m_woq_autoround_int4_hpu, not opt_125m_woq_autoround_int4, after removing environment variables and using requirement-autoround-hpu.txt in validation codes.

@yiliu30
Copy link
Contributor

yiliu30 commented Dec 25, 2024

@xin3he @XuehaoSun suggest testing the auto-round on the CPU as well.

@xin3he
Copy link
Contributor Author

xin3he commented Dec 25, 2024

cpu: https://inteltf-jenk.sh.intel.com/view/lpot-validation/job/intel-lpot-validation-top-mr-extension/5596/

@xin3he
Copy link
Contributor Author

xin3he commented Dec 25, 2024

Verify complete GPTQ test based on #2100
https://inteltf-jenk.sh.intel.com/job/inc_gaudi_test/156/

@chensuyue chensuyue merged commit 37c4552 into master Dec 25, 2024
25 checks passed
@chensuyue chensuyue deleted the xinhe/doc branch December 25, 2024 08:55
@xin3he
Copy link
Contributor Author

xin3he commented Dec 25, 2024

The CPU test failed @XuehaoSun, please help verify the validation machine environment issue.

This issue is not related to this PR and this PR didn't change CPU related logic. so we merge it first for release test. @yiliu30

@yiliu30
Copy link
Contributor

yiliu30 commented Dec 25, 2024

The CPU test failed @XuehaoSun, please help verify the validation machine environment issue.

This issue is not related to this PR and this PR didn't change CPU related logic. so we merge it first for release test. @yiliu30

@xin3he It's fine with me. Please create a Jira to track it in case we miss it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants