This repository was archived by the owner on Jan 7, 2023. It is now read-only.
rename lib name to gralloc.broxton #91
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feijiang1
reviewed
Dec 6, 2019
| "mediatek.c", | ||
| "meson.c", | ||
| "msm.c", | ||
| "nouveau.c", |
There was a problem hiding this comment.
nouveau is for nvidia card, should also be deleted
Contributor
There was a problem hiding this comment.
If this blueprint file is from upstream, it would be best to keep all these lines and avoid number of changes against upstream. It would be then easier to rebase in the future when we update our minigbm from upstream?
There was a problem hiding this comment.
Due to we need change the Android.bp, then we prefer to keep the Android.bp clean.
feijiang1
reviewed
Dec 6, 2019
| ], | ||
| } | ||
|
|
||
| cc_library_shared { |
There was a problem hiding this comment.
It is better still keep libminigbm, which can be used as test purpose
feijiang1
reviewed
Dec 6, 2019
| srcs: [ | ||
| "amdgpu.c", | ||
| "drv.c", | ||
| "evdi.c", |
To avoid lib name conflicts from external minigbm. Tracked-On: OAM-88753 Signed-off-by: yifang ma <yifangx.ma@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid lib name conflicts from external minigbm.
Tracked-On: OAM-88753
Signed-off-by: yifang ma yifangx.ma@intel.com