Skip to content

Conversation

@hcymerys
Copy link
Contributor

This pull request introduces significant updates to the repository, including new workflows, documentation improvements, and code examples. The most important changes involve the addition of reusable GitHub Actions workflows for CI/CD, enhanced documentation files, and a simple example demonstrating the usage of the mfd-sysctl module.

Workflow Enhancements:

Documentation Updates:

  • AUTHORS.md: Added a list of contributors to the project.
  • CONTRIBUTING.md: Updated the project name and license reference for contributors.
  • LICENSE.md: Added the MIT license file for the project.
  • README.md: Provided detailed usage instructions, supported methods, enums, constants, and supported operating systems for the mfd-sysctl module.

Code Examples:

  • examples/simple_example.py: Introduced a simple example demonstrating various functionalities of the mfd-sysctl module, such as retrieving sysctl values, setting configurations, and interacting with network adapters.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

This comment was marked as outdated.

@mfd-intel-bot
Copy link

We don't publish DEVs .whl.
To build .whl, run 'pip install git+https://github.com/intel/mfd-sysctl@first'

1 similar comment
@mfd-intel-bot
Copy link

We don't publish DEVs .whl.
To build .whl, run 'pip install git+https://github.com/intel/mfd-sysctl@first'

@mfd-intel-bot
Copy link

We don't publish DEVs .whl.
To build .whl, run 'pip install git+https://github.com/intel/mfd-sysctl@first'

1 similar comment
@mfd-intel-bot
Copy link

We don't publish DEVs .whl.
To build .whl, run 'pip install git+https://github.com/intel/mfd-sysctl@first'

@mfd-intel-bot
Copy link

We don't publish DEVs .whl.
To build .whl, run 'pip install git+https://github.com/intel/mfd-sysctl@first'

1 similar comment
@mfd-intel-bot
Copy link

We don't publish DEVs .whl.
To build .whl, run 'pip install git+https://github.com/intel/mfd-sysctl@first'

@hcymerys hcymerys requested a review from Copilot July 10, 2025 09:30

This comment was marked as outdated.

@mfd-intel-bot
Copy link

We don't publish DEVs .whl.
To build .whl, run 'pip install git+https://github.com/intel/mfd-sysctl@first'

1 similar comment
@mfd-intel-bot
Copy link

We don't publish DEVs .whl.
To build .whl, run 'pip install git+https://github.com/intel/mfd-sysctl@first'

@hcymerys hcymerys requested a review from Copilot July 10, 2025 09:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This initial commit adds the core mfd-sysctl implementation, accompanying tests, documentation scaffolding, and CI/CD workflows.

  • Introduces Sysctl base class with Linux and FreeBSD subclasses and full API surface
  • Adds unit tests for both Linux and FreeBSD implementations
  • Sets up Sphinx-based documentation and reusable GitHub Actions workflows

Reviewed Changes

Copilot reviewed 31 out of 35 changed files in this pull request and generated no comments.

File Description
tests/unit/test_mfd_sysctl/test_mfd_sysctl_linux.py Adds Linux-specific unit tests for LinuxSysctl
mfd_sysctl/linux.py Implements LinuxSysctl methods: busy_poll, buffer sizing, IPv6
examples/simple_example.py Provides a simple example demonstrating the Sysctl API
sphinx-doc/conf.py Adds Sphinx configuration for generating module documentation
Comments suppressed due to low confidence (4)

examples/simple_example.py:16

  • get_sysctl_value is only implemented in the FreeBSD subclass, so calling it on a LinuxSysctl instance will result in an AttributeError. Either add equivalents to the Linux subclass or adjust the example to use Linux-only methods.
print(sysctl_obj.get_sysctl_value("dev.igb.0.fc"))

sphinx-doc/conf.py:43

  • [nitpick] autodoc_default_flags is deprecated in newer Sphinx versions; consider using autodoc_default_options to prevent deprecation warnings.
autodoc_default_flags = ["members", "undoc-members", "private-members", "inherited-members", "show-inheritance"]

tests/unit/test_mfd_sysctl/test_mfd_sysctl_linux.py:34

  • Calling mocker.stopall() inside the fixture will undo all test patches before the tests run, which may cause real code execution instead of using mocks. Consider removing this call or moving cleanup to a fixture finalizer so that the patches remain active during tests.
        mocker.stopall()

mfd_sysctl/linux.py:58

  • The sysctl variables should use dot notation (e.g. net.core.rmem_max) rather than slash separators, otherwise the commands will fail on Linux.
        core_buffers = ("net/core/rmem_max", "net/core/wmem_max")

@hcymerys hcymerys merged commit e2fb699 into main Jul 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants