Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VP8 CQP encoding. #622

Merged
merged 1 commit into from
May 21, 2019
Merged

Fix VP8 CQP encoding. #622

merged 1 commit into from
May 21, 2019

Conversation

wangyan42164
Copy link
Contributor

  1. Initialize BRC variales for avoiding wrong DSH allocation.
  2. Set the right CQP enum number (RATECONTROL_CQP = 3).
  3. Avoid division by zero in CQP mode.
    Fixes [ffmpeg-vaapi][VP8 encode] floating point exception #578.

Signed-off-by: Yan Wang yan.wang@linux.intel.com

@wangyan-intel wangyan-intel mentioned this pull request May 14, 2019
Closed
eero-t
eero-t reviewed May 14, 2019
View reviewed changes
Copy link

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to use a define (RATECONTROL_CQP), rather than a magic value (3).

@wangyan-intel
Copy link

@eero-t Yes. Just keep consistent with another 2 branches (CBR/VBR). I can refined all branches.

@wangyan42164
Fix VP8 CQP encoding.
81fbb29 
1. Initialize BRC variales for avoiding wrong DSH allocation.
2. Set the right CQP enum number (RATECONTROL_CQP = 3).
3. Avoid division by zero in CQP mode.
Fixes intel#578.

Signed-off-by: Yan Wang <yan.wang@linux.intel.com>
@wangyan-intel wangyan-intel added the verifying PR: fix ready and verifying with build/test label May 21, 2019
@intel-mediadev intel-mediadev merged commit 80d8db4 into intel:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eero-t eero-t eero-t left review comments

@Xiaogangli-intel Xiaogangli-intel Xiaogangli-intel approved these changes

Assignees
No one assigned
Labels
verifying PR: fix ready and verifying with build/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ffmpeg-vaapi][VP8 encode] floating point exception
5 participants
@wangyan42164 @wangyan-intel @eero-t @Xiaogangli-intel @intel-mediadev