Skip to content

keep quality level until new VAEncMiscParameterBufferQualityLevel #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

XinfengZhang
Copy link
Contributor

fix #7

Signed-off-by: XinfengZhang carl.zhang@intel.com

@@ -115,7 +115,7 @@ VAStatus DdiEncodeHevc::ContextInitialize(
codecHalSettings->pCpParams = m_encodeCtx->pCpDdiInterface->GetParams();

VAStatus eStatus = VA_STATUS_SUCCESS;

m_encodeCtx->targetUsage = TARGETUSAGE_RT_SPEED;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the HEVC target usage also be initialized to BEST_QUALITY? Or the default usage of AVC/MPEG2 is set to RT_SPEED?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, all will be unified set default to RT_SPEED

Copy link
Contributor

@yakuizhao yakuizhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one minor comment.
It will be better that the default target usage is used for AVC/HEVC/MPEG2.

@XinfengZhang XinfengZhang requested a review from liangali January 4, 2018 03:47
@XinfengZhang
Copy link
Contributor Author

@applewang001

fix intel#7

Signed-off-by: XinfengZhang <carl.zhang@intel.com>
@oliver-sang oliver-sang merged commit ea892df into intel:master Jan 31, 2018
oliver-sang pushed a commit that referenced this pull request Jan 31, 2018
…#734426)

fix #7, PR #56
Signed-off-by: XinfengZhang <carl.zhang@intel.com>

Change-Id: I635d509c2b7066ffd71018b2ec3faf9908bff6a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VAEncMiscParameterBufferQualityLevel need to reset for AVC/HEVC when sequence parameters reset.
3 participants