Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffmpeg-vaapi][max_frame_size][vaGetConfigAttributes][Enhancement] #643

Closed
fulinjie opened this issue Jun 12, 2019 · 5 comments · Fixed by #656
Closed

[ffmpeg-vaapi][max_frame_size][vaGetConfigAttributes][Enhancement] #643

fulinjie opened this issue Jun 12, 2019 · 5 comments · Fixed by #656
Labels
Encode video encode related

Comments

@fulinjie
Copy link
Contributor

Since VAConfigAttribMaxFrameSize has been added in libva,intel/libva@dcbd65b
IMHO, m_attributes for m_profileEntryTbl need to be added too to make the query for max_frame_size valid.

Message:
[h264_vaapi @ 0x5594b51cbec0] Max frame size attribute is not supported.

p (*m_profileEntryTbl[1].m_attributes)
$21 = std::map with 8 elements = {[VAConfigAttribRTFormat] = 131075, [VAConfigAttribEncryption] = 2147483648, [VAConfigAttribDecSliceMode] = 3, [VAConfigAttribDecProcessing] = 1,
[VAConfigAttribMaxPictureWidth] = 8192, [VAConfigAttribMaxPictureHeight] = 8192, [VAConfigAttribProcessingRate] = 2, [VAConfigAttribCustomRoundingControl] = 1}

@wangyan42164
Copy link
Contributor

@fulinjie I submitted #656 to fix it. It works fine on my side. Could you please try it? Thanks.

@wangyan-intel wangyan-intel added the Encode video encode related label Jun 19, 2019
@fulinjie
Copy link
Contributor Author

@wangyan42164 thanks Yan, it works in avc encoder and returns expected attrib.value for VAEncMiscParameterTypeMultiPassFrameSize.

A remained concern:
Is there any plan to support VAEncMiscParameterTypeMaxFrameSize which is also defined in libva?

If no, i would like to consider the multi path solution only.

@wangyan42164
Copy link
Contributor

@fulinjie VAEncMiscParameterTypeMaxFrameSize has been supported in current media driver.

@wangyan-intel
Copy link

@fulinjie I checked the code of media driver. VAEncMiscParameterTypeMaxFrameSize should be for VP8/9 only. VAEncMiscParameterTypeMultiPassFrameSize is for AVC only. Thanks.

@fulinjie
Copy link
Contributor Author

Thanks a lot.

intel-mediadev pushed a commit that referenced this issue Jul 12, 2019
Fixes #643.

Signed-off-by: Yan Wang <yan.wang@linux.intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Encode video encode related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants