-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ffmpeg-vaapi][max_frame_size][vaGetConfigAttributes][Enhancement] #643
Comments
Fixes intel#643. Signed-off-by: Yan Wang <yan.wang@linux.intel.com>
@wangyan42164 thanks Yan, it works in avc encoder and returns expected attrib.value for VAEncMiscParameterTypeMultiPassFrameSize. A remained concern: If no, i would like to consider the multi path solution only. |
@fulinjie VAEncMiscParameterTypeMaxFrameSize has been supported in current media driver. |
@fulinjie I checked the code of media driver. VAEncMiscParameterTypeMaxFrameSize should be for VP8/9 only. VAEncMiscParameterTypeMultiPassFrameSize is for AVC only. Thanks. |
Thanks a lot. |
Fixes #643. Signed-off-by: Yan Wang <yan.wang@linux.intel.com>
Since VAConfigAttribMaxFrameSize has been added in libva,intel/libva@dcbd65b
IMHO, m_attributes for m_profileEntryTbl need to be added too to make the query for max_frame_size valid.
Message:
[h264_vaapi @ 0x5594b51cbec0] Max frame size attribute is not supported.
p (*m_profileEntryTbl[1].m_attributes)
$21 = std::map with 8 elements = {[VAConfigAttribRTFormat] = 131075, [VAConfigAttribEncryption] = 2147483648, [VAConfigAttribDecSliceMode] = 3, [VAConfigAttribDecProcessing] = 1,
[VAConfigAttribMaxPictureWidth] = 8192, [VAConfigAttribMaxPictureHeight] = 8192, [VAConfigAttribProcessingRate] = 2, [VAConfigAttribCustomRoundingControl] = 1}
The text was updated successfully, but these errors were encountered: