Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gst-vaapi][ICL][Dec] when use Y410 to vaCreateImage, the image num_planes will return 0. #431

Closed
feiwan1 opened this issue Nov 27, 2018 · 2 comments · Fixed by #459
Closed
Labels
verifying PR: fix ready and verifying with build/test

Comments

@feiwan1
Copy link
Contributor

feiwan1 commented Nov 27, 2018

Need to add Y410 in vaCreateImage and vaPutImage.

When decode a hevc 444 10bit stream by gst-vaapi, will reproduce this issue:

root@icl_vpg_kernel:~/media# gst-launch-1.0 filesrc location=Main444_10bit.h265 ! h265parse ! vaapih265dec ! fakesink
Setting pipeline to PAUSED ...
Pipeline is PREROLLING ...
Got context from element 'vaapidecode_h265-0': gst.gl.GLDisplay=context, gst.gl.GLDisplay=(GstGLDisplay)"(GstGLDisplayX11)\ gldisplayx11-0";
Got context from element 'vaapidecode_h265-0': gst.vaapi.Display=context, gst.vaapi.Display=(GstVaapiDisplay)"(GstVaapiDisplayX11)\ vaapidisplayx11-0";
Redistribute latency...
** (gst-launch-1.0:7237): CRITICAL **: gst_video_info_update_from_image: assertion 'num_planes == GST_VIDEO_INFO_N_PLANES (vip)' failed

Note: this issue need 2 patches in gst-plugins-base and gstreamer-vaapi which will support Y410 and 444 10bit decode:
gst-plugin-base:
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/merge_requests/34
gstreamer-vaapi:
https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/merge_requests/22

@wangyan42164
Copy link
Contributor

Will check it. Thanks.

@feiwan1
Copy link
Contributor Author

feiwan1 commented Dec 11, 2018

Update, the 2 patch in gst-plugin-base and gstreamer-vaapi already merged. So can use master of them to reproduce this issue, don't need to additional patch.

XinfengZhang added a commit to XinfengZhang/media-driver that referenced this issue Dec 12, 2018
Fixes intel#431

Signed-off-by: XinfengZhang <carl.zhang@intel.com>
@XinfengZhang XinfengZhang added the verifying PR: fix ready and verifying with build/test label Dec 12, 2018
wangyan42164 added a commit to wangyan42164/media-driver that referenced this issue Dec 12, 2018
Fixes intel#431.

Signed-off-by: Yan Wang <yan.wang@linux.intel.com>
XinfengZhang added a commit to XinfengZhang/media-driver that referenced this issue Apr 10, 2019
Fixes intel#431

Signed-off-by: XinfengZhang <carl.zhang@intel.com>
XinfengZhang added a commit to XinfengZhang/media-driver that referenced this issue Apr 16, 2019
Fixes intel#431

Signed-off-by: XinfengZhang <carl.zhang@intel.com>
intel-mediadev pushed a commit that referenced this issue Apr 16, 2019
Fixes #431

Signed-off-by: XinfengZhang <carl.zhang@intel.com>
djie1 pushed a commit to djie1/media-driver that referenced this issue May 20, 2019
Fixes intel#431

Signed-off-by: XinfengZhang <carl.zhang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verifying PR: fix ready and verifying with build/test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants