Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add more notes on docker setup #150

Merged
merged 1 commit into from
Feb 8, 2023
Merged

doc: add more notes on docker setup #150

merged 1 commit into from
Feb 8, 2023

Conversation

dvrogozh
Copy link
Contributor

@dvrogozh dvrogozh commented Feb 8, 2023

Signed-off-by: Dmitry Rogozhkin dmitry.v.rogozhkin@intel.com

Copy link
Contributor

@mkpatel3-github mkpatel3-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me..

Copy link
Contributor

@dsocek dsocek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small fix suggested

README.rst Outdated

* Consider to register and login to `Docker Hub <https://hub.docker.com/>`_. Docker Hub
limits the number of docker image downloads ("pulls"). For anonymous users this limit
is tight to IP address. For authenticated users it depends on subscription type. For
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tight = tied

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
@dvrogozh dvrogozh merged commit 3bafe3c into intel:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants