[SYCL][COMPAT] SYCLcompat dim and defs headers #9976

Alcpz · 2023-06-19T15:23:34Z

This is an implementation of SYCLcompat, the stand alone library proposed in #9646.
Please, find the documentation there.

SYCLcompat has two primary goals:

Improve the adoption of SYCL. This library is designed to provide a familiar programming interface that resembles other popular heterogeneous programming models. By reducing the learning curve, it enables developers to leverage SYCL's power and features more easily.
Source-to-Source Translation Support. SYCLcompat is also designed to facilitate automatic source-to-source translation from other heterogeneous programming models to SYCL and offer a more standardized and consistent programming interface. This feature can significantly streamline the migration and integration of existing codebases into the SYCL ecosystem

The PR also includes tests. We were advised to include the tests as part of sycl/unittests, so we added a different mechanism to build them using clang.

As we stated in the docs PR, we are open to any suggestions, concerns, or improvements you may have, so please, let us know if you have any.

Alcpz · 2023-06-19T15:59:33Z

Documentation available in a different PR: #9646

aelovikov-intel · 2023-06-20T15:41:28Z

Should we add a dedicated owner in CODEOWNERS file for this compat library?

sycl/unittests/CMakeLists.txt

sycl/unittests/syclcompat/Defs.cpp

Alcpz · 2023-06-26T11:21:28Z

Should we add a dedicated owner in CODEOWNERS file for this compat library?

@aelovikov-intel I've added sycl/doc/syclcompat/CodeOwners.rst with the code owners for SYCLcompat. We will ask for the review group following this.

aelovikov-intel · 2023-06-26T14:49:11Z

Should we add a dedicated owner in CODEOWNERS file for this compat library?

@aelovikov-intel I've added sycl/doc/syclcompat/CodeOwners.rst with the code owners for SYCLcompat. We will ask for the review group following this.

Why not an entry in https://github.com/intel/llvm/blob/sycl/.github/CODEOWNERS?

Alcpz · 2023-06-27T10:00:39Z

Should we add a dedicated owner in CODEOWNERS file for this compat library?

@aelovikov-intel I've added sycl/doc/syclcompat/CodeOwners.rst with the code owners for SYCLcompat. We will ask for the review group following this.

Why not an entry in https://github.com/intel/llvm/blob/sycl/.github/CODEOWNERS?

Good point, that is actually better. I will update that once we have a review group set up.

Alcpz · 2023-06-29T08:25:02Z

We have requested for the syclcompat-lib-reviewers group. The CODEOWNERS will be updated in a different request.

Alcpz · 2023-07-11T11:22:28Z

@aelovikov-intel the entry in the CODEOWNERS file has been merged.

Co-Authored-By: Gordon Brown <gordon@codeplay.com> Co-Authored-By: Joe Todd <joe.todd@codeplay.com> Co-Authored-By: Pietro Ghiglio <pietro.ghiglio@codeplay.com> Co-Authored-By: Ruyman Reyes <ruyman@codeplay.com>

Co-authored-by: tomflinda <tomflinda@gmail.com>

joeatodd

LGTM

joeatodd · 2023-08-08T13:21:37Z

We're not really sure why @intel/dpcpp-doc-reviewers was requested for a review (possibly due to link with this PR). Could someone have a quick look? Thanks!

dm-vodopyanov · 2023-08-08T13:27:44Z

The PR has all required approvals, waiting for CI completion to be able to merge.

This pull request introduces a new stand alone library, `SYCLcompat`: a simplified wrapper on top of SYCL, aiming to make it more accessible to developers familiar with other heterogeneous programming models. SYCLcompat has two primary goals: - Improve the adoption of SYCL. This library is designed to provide a familiar programming interface that resembles other popular heterogeneous programming models. By reducing the learning curve, it enables developers to leverage SYCL's power and features more easily. - Source-to-Source Translation Support. SYCLcompat is also designed to facilitate automatic source-to-source translation from other heterogeneous programming models to SYCL and offer a more standardized and consistent programming interface. This feature can significantly streamline the migration and integration of existing codebases into the SYCL ecosystem. The first commit of this PR includes the proposed library README, providing explanation of its motivation, public interface, usage guidelines, and code examples. A set of PRs will follow, including subsets of the current implementation including their tests. We are open to any suggestions, concerns, or improvements you may have, so please, let us know if you have any. Edit: Updated from extension to stand alone library. #9976 `dims.hpp` and `defs.hpp` headers --------- Co-authored-by: Gordon Brown <gordon@codeplay.com> Co-authored-by: Joe Todd <joe.todd@codeplay.com> Co-authored-by: Pietro Ghiglio <pietro.ghiglio@codeplay.com> Co-authored-by: Ruyman Reyes <ruyman@codeplay.com> Co-authored-by: Steffen Larsen <steffen.larsen@intel.com> Co-authored-by: aelovikov-intel <andrei.elovikov@intel.com> Co-authored-by: Sami Hatna <sami.hatna@codeplay.com> Co-authored-by: Joe Todd <joeatodd@users.noreply.github.com> Co-authored-by: Alexey Bader <alexey.bader@intel.com>

Alcpz · 2023-08-09T12:34:34Z

@intel/llvm-gatekeepers CI is finally passing. We think it's ready to merge. Thanks!

This commit reverts the changes introduced in intel#9976 to sycl/unittests. It also removes the gtest suite from syclcompat Rationale: We need device code to test the following syclcompat PRs. Changes: - Removed sycl/cmake/modules/AddSYCLLibraryUnittest.cmake as it was only used here, this has also introduced overhead to people working in the Unittests CI, it is better for them to remove the need to maintain this. - Reverted syclcompat changes in sycl/unittests/CMakeLists.txt - Refactored sycl/unittests/syclcompat to sycl/test-e2e/syclcompat

This pull request introduces a new stand alone library, `SYCLcompat`: a simplified wrapper on top of SYCL, aiming to make it more accessible to developers familiar with other heterogeneous programming models. SYCLcompat has two primary goals: - Improve the adoption of SYCL. This library is designed to provide a familiar programming interface that resembles other popular heterogeneous programming models. By reducing the learning curve, it enables developers to leverage SYCL's power and features more easily. - Source-to-Source Translation Support. SYCLcompat is also designed to facilitate automatic source-to-source translation from other heterogeneous programming models to SYCL and offer a more standardized and consistent programming interface. This feature can significantly streamline the migration and integration of existing codebases into the SYCL ecosystem. The first commit of this PR includes the proposed library README, providing explanation of its motivation, public interface, usage guidelines, and code examples. A set of PRs will follow, including subsets of the current implementation including their tests. We are open to any suggestions, concerns, or improvements you may have, so please, let us know if you have any. Edit: Updated from extension to stand alone library. intel#9976 `dims.hpp` and `defs.hpp` headers --------- Co-authored-by: Gordon Brown <gordon@codeplay.com> Co-authored-by: Joe Todd <joe.todd@codeplay.com> Co-authored-by: Pietro Ghiglio <pietro.ghiglio@codeplay.com> Co-authored-by: Ruyman Reyes <ruyman@codeplay.com> Co-authored-by: Steffen Larsen <steffen.larsen@intel.com> Co-authored-by: aelovikov-intel <andrei.elovikov@intel.com> Co-authored-by: Sami Hatna <sami.hatna@codeplay.com> Co-authored-by: Joe Todd <joeatodd@users.noreply.github.com> Co-authored-by: Alexey Bader <alexey.bader@intel.com>

This is an implementation of SYCLcompat, the stand alone library proposed in intel#9646. Please, find the documentation there. SYCLcompat has two primary goals: - Improve the adoption of SYCL. This library is designed to provide a familiar programming interface that resembles other popular heterogeneous programming models. By reducing the learning curve, it enables developers to leverage SYCL's power and features more easily. - Source-to-Source Translation Support. SYCLcompat is also designed to facilitate automatic source-to-source translation from other heterogeneous programming models to SYCL and offer a more standardized and consistent programming interface. This feature can significantly streamline the migration and integration of existing codebases into the SYCL ecosystem The PR also includes tests. We were advised to include the tests as part of `sycl/unittests`, so we added a different mechanism to build them using `clang`. As we stated in the docs PR, we are open to any suggestions, concerns, or improvements you may have, so please, let us know if you have any. --------- Co-authored-by: Gordon Brown <gordon@codeplay.com> Co-authored-by: Joe Todd <joe.todd@codeplay.com> Co-authored-by: Pietro Ghiglio <pietro.ghiglio@codeplay.com> Co-authored-by: Ruyman Reyes <ruyman@codeplay.com> Co-authored-by: tomflinda <tomflinda@gmail.com>

Alcpz requested a review from a team as a code owner June 19, 2023 15:23

Alcpz requested a review from aelovikov-intel June 19, 2023 15:23

Alcpz temporarily deployed to aws June 19, 2023 15:38 — with GitHub Actions Inactive

This was referenced Jun 19, 2023

[SYCL][COMPAT] First sycl_ext_oneapi_compat implementation #9755

Closed

[SYCL][COMPAT][Doc] Add SYCLcompat documentation #9646

Merged

Alcpz temporarily deployed to aws June 19, 2023 16:05 — with GitHub Actions Inactive

Alcpz force-pushed the Alcpz/impl-SYCLcompat branch from a6808ed to 0bcf97c Compare June 19, 2023 16:37

Alcpz temporarily deployed to aws June 19, 2023 16:52 — with GitHub Actions Inactive

Alcpz temporarily deployed to aws June 19, 2023 17:31 — with GitHub Actions Inactive

Alcpz temporarily deployed to aws June 20, 2023 09:44 — with GitHub Actions Inactive

Alcpz force-pushed the Alcpz/impl-SYCLcompat branch from 2b290d9 to cf4388e Compare June 20, 2023 10:55

Alcpz temporarily deployed to aws June 20, 2023 11:11 — with GitHub Actions Inactive

Alcpz temporarily deployed to aws June 20, 2023 11:50 — with GitHub Actions Inactive

aelovikov-intel reviewed Jun 20, 2023

View reviewed changes

sycl/unittests/CMakeLists.txt Show resolved Hide resolved

sycl/unittests/syclcompat/Defs.cpp Outdated Show resolved Hide resolved

Alcpz requested a review from a team as a code owner June 26, 2023 11:12

Alcpz temporarily deployed to aws June 26, 2023 11:29 — with GitHub Actions Inactive

Alcpz temporarily deployed to aws June 26, 2023 12:10 — with GitHub Actions Inactive

Alcpz force-pushed the Alcpz/impl-SYCLcompat branch from 81acc0e to 8f00fb0 Compare June 29, 2023 08:30

Alcpz temporarily deployed to aws June 29, 2023 09:25 — with GitHub Actions Inactive

Alcpz temporarily deployed to aws June 29, 2023 10:36 — with GitHub Actions Inactive

aelovikov-intel approved these changes Jul 11, 2023

View reviewed changes

bader requested a review from a team July 11, 2023 23:19

Alcpz temporarily deployed to aws July 12, 2023 15:51 — with GitHub Actions Inactive

joeatodd temporarily deployed to aws August 7, 2023 15:43 — with GitHub Actions Inactive

joeatodd temporarily deployed to aws August 8, 2023 09:35 — with GitHub Actions Inactive

joeatodd temporarily deployed to aws August 8, 2023 13:01 — with GitHub Actions Inactive

Alcpz and others added 8 commits August 8, 2023 14:08

[SYCL][COMPAT] Dim3 and macro definitions added.

d80109e

Co-Authored-By: Gordon Brown <gordon@codeplay.com> Co-Authored-By: Joe Todd <joe.todd@codeplay.com> Co-Authored-By: Pietro Ghiglio <pietro.ghiglio@codeplay.com> Co-Authored-By: Ruyman Reyes <ruyman@codeplay.com>

[SYCL][COMPAT] Fix wrong name for defs.hpp in syclcompat.hpp

3bfd299

Co-authored-by: tomflinda <tomflinda@gmail.com>

[SYCL][COMPAT] Improved some comments and file headers

9dbe877

[SYCL][COMPAT] Refactored outside of sycl include path

6c0c092

[SYCL][COMPAT] Improved defs test suite name

ea4902f

[SYCL][COMPAT] Added dependency to SYCLUnitTests target

f36ff23

[SYCL][COMPAT] Improved Windows library unittests

ac97108

[SYCL][COMPAT] Fixed missing libraries when linking unittests

a053235

joeatodd force-pushed the Alcpz/impl-SYCLcompat branch from 7bd264b to 58fa573 Compare August 8, 2023 13:08

joeatodd approved these changes Aug 8, 2023

View reviewed changes

joeatodd had a problem deploying to aws August 8, 2023 13:18 — with GitHub Actions Failure

dm-vodopyanov removed the request for review from a team August 8, 2023 13:25

joeatodd and others added 2 commits August 9, 2023 10:03

[SYCL][COMPAT] Formatting

2376acc

Merge remote-tracking branch 'intel/sycl' into Alcpz/impl-SYCLcompat

3310dad

Alcpz force-pushed the Alcpz/impl-SYCLcompat branch from 58fa573 to 3310dad Compare August 9, 2023 09:21

dm-vodopyanov merged commit bedd818 into intel:sycl Aug 9, 2023

Alcpz deleted the Alcpz/impl-SYCLcompat branch August 9, 2023 13:38

Alcpz mentioned this pull request Aug 17, 2023

[SYCL][COMPAT] Added device extension and manager #10774

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SYCL][COMPAT] SYCLcompat dim and defs headers #9976

[SYCL][COMPAT] SYCLcompat dim and defs headers #9976

Uh oh!

Alcpz commented Jun 19, 2023

Uh oh!

Alcpz commented Jun 19, 2023

Uh oh!

aelovikov-intel commented Jun 20, 2023

Uh oh!

Uh oh!

Uh oh!

Alcpz commented Jun 26, 2023 •

edited

Loading

Uh oh!

aelovikov-intel commented Jun 26, 2023

Uh oh!

Alcpz commented Jun 27, 2023

Uh oh!

Alcpz commented Jun 29, 2023

Uh oh!

Alcpz commented Jul 11, 2023

Uh oh!

joeatodd left a comment

Uh oh!

joeatodd commented Aug 8, 2023

Uh oh!

dm-vodopyanov commented Aug 8, 2023

Uh oh!

Alcpz commented Aug 9, 2023

Uh oh!

Uh oh!

[SYCL][COMPAT] SYCLcompat dim and defs headers #9976

[SYCL][COMPAT] SYCLcompat dim and defs headers #9976

Uh oh!

Conversation

Alcpz commented Jun 19, 2023

Uh oh!

Alcpz commented Jun 19, 2023

Uh oh!

aelovikov-intel commented Jun 20, 2023

Uh oh!

Uh oh!

Uh oh!

Alcpz commented Jun 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aelovikov-intel commented Jun 26, 2023

Uh oh!

Alcpz commented Jun 27, 2023

Uh oh!

Alcpz commented Jun 29, 2023

Uh oh!

Alcpz commented Jul 11, 2023

Uh oh!

joeatodd left a comment

Choose a reason for hiding this comment

Uh oh!

joeatodd commented Aug 8, 2023

Uh oh!

dm-vodopyanov commented Aug 8, 2023

Uh oh!

Alcpz commented Aug 9, 2023

Uh oh!

Uh oh!

Alcpz commented Jun 26, 2023 •

edited

Loading