Skip to content

[SYCL] Const-qualify sycl::logical_{or, and} #9861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2023
Merged

[SYCL] Const-qualify sycl::logical_{or, and} #9861

merged 1 commit into from
Jun 14, 2023

Conversation

jzc
Copy link
Contributor

@jzc jzc commented Jun 14, 2023 •
edited
Loading

These operators were changed from aliasing their std counterparts in #9298 but a const-qualification was not added (as required by 4.17.2. Function objects).

@jzc jzc requested a review from a team as a code owner June 14, 2023 00:52
@jzc jzc requested a review from aelovikov-intel June 14, 2023 00:52
@jzc jzc temporarily deployed to aws June 14, 2023 01:08 — with GitHub Actions Inactive
@jzc jzc temporarily deployed to aws June 14, 2023 01:48 — with GitHub Actions Inactive
@aelovikov-intel
Copy link
Contributor

but in #9298 but a const-qualification was not added

This reads weird. Should the second but be dropped?

@jzc
Copy link
Contributor Author

jzc commented Jun 14, 2023

but in #9298 but a const-qualification was not added

This reads weird. Should the second but be dropped?

Yea, definitely a typo. Although, the sentence reads fine if the second "but" is dropped I think my original intention was without the first "but", i.e. "the operators were changed [...] in #9298" joined with "but" to "a const-qualification was not added [...]" to emphasize that #9298 did not add it.

@aelovikov-intel aelovikov-intel merged commit 90406b2 into intel:sycl Jun 14, 2023
fineg74 pushed a commit to fineg74/llvm that referenced this pull request Jun 15, 2023
@jzc @fineg74
[SYCL] Const-qualify sycl::logical_{or, and} (intel#9861)
1e8d6e5 
These operators were changed from aliasing their `std` counterparts in
intel#9298 but a const-qualification was
not added (as required by [4.17.2. Function
objects](https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#sec:function-objects)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzc @aelovikov-intel