[SYCL] Disable the ZE_DEBUG tests on Windows #9854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not run ZE_DEBUG tests on Windows. Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
|
FYI this is per plan/discussion. on Windows there is several cases where ZE_DEBUG tests fail due to how we handle certain resources and letting windows clean them up. So in this case, the agreed upon approach is to disable tests that are failing and we have reviewed and verified that its expected to fail. |
stdale-intel
approved these changes
Jun 13, 2023
steffenlarsen
approved these changes
Jun 14, 2023
fineg74
pushed a commit
to fineg74/llvm
that referenced
this pull request
Jun 15, 2023
We should not run ZE_DEBUG tests on Windows. --------- Signed-off-by: Byoungro So <byoungro.so@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not run ZE_DEBUG tests on Windows.