Skip to content

[CI] Move lint job to self-hosted runner #9844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented Jun 13, 2023

Github's allocation of default ubuntu-* runners isn't reliably stable,
so keep moving tasks to self hosted runners. We don't use the cuda runner
currently, so assign those to it for the time being. Later we should be
able to extend those utility tasks to run on generic Linux class of
self-hosted runners.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner June 13, 2023 14:50
@aelovikov-intel
Copy link
Contributor Author

# actions/checkout is run from within another action step (not from
# workflow), github seems to try to download from within the container
# and doesn't have requried filesystem permissions. Make sure it's
# already downloaded by the time it's needed by checking out some small
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'm not understanding this. "by checking out some small repository". Checking out what, exactly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repository: actions/checkout - we use it to checkout itself.

@aelovikov-intel
Copy link
Contributor Author

Failure is expected - the task took clang-format/action.yml from the PR while pre_commit.yml is used from origin/sycl due to security reasons.

@aelovikov-intel aelovikov-intel merged commit 2e6f732 into intel:sycl Jun 13, 2023
@aelovikov-intel aelovikov-intel deleted the lint-cuda-review branch June 13, 2023 17:55
aelovikov-intel added a commit that referenced this pull request Jun 14, 2023
#9844 somehow caused problems with
lint tasks when `origin/sycl` is newer than PR's merge base with it. I
don't understand how that wasn't a problem before, but let's try to fix
it.

While on it, start using sparse checkout to get
`devops/actions/cached_checkout` instead of "wget".
aelovikov-intel added a commit that referenced this pull request Jun 14, 2023
#9844 somehow caused problems with
lint tasks when `origin/sycl` is newer than PR's merge base with it. I
don't understand how that wasn't a problem before, but let's try to fix
it.

While on it, start using sparse checkout to get
`devops/actions/cached_checkout` instead of "wget".
fineg74 pushed a commit to fineg74/llvm that referenced this pull request Jun 15, 2023
Github's allocation of default ubuntu-* runners isn't reliably stable,
so keep moving tasks to self hosted runners. We don't use the cuda
runner currently, so assign those to it for the time being. Later we 
should be able to extend those utility tasks to run on generic `Linux` 
class of self-hosted runners.
fineg74 pushed a commit to fineg74/llvm that referenced this pull request Jun 15, 2023
intel#9844 somehow caused problems with
lint tasks when `origin/sycl` is newer than PR's merge base with it. I
don't understand how that wasn't a problem before, but let's try to fix
it.

While on it, start using sparse checkout to get
`devops/actions/cached_checkout` instead of "wget".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants