Skip to content

[SYCL][NFC] Fix a warning about mismatch tag in type_list declaration and definition #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

s-kanaev
Copy link
Contributor

@s-kanaev s-kanaev commented Dec 30, 2019

Compiling user code with -Wall provides compilation warnings from SYCL headers.
In some cases (-Werror or smth like that is enabled) it may not allow to compile user code.

Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, clarify in the commit message what warning you are trying to fix.

@bader bader changed the title [SYCL] [NFC] Fix warning [SYCL][NFC] Fix warning Dec 30, 2019
@s-kanaev
Copy link
Contributor Author

Updated description

@bader
Copy link
Contributor

bader commented Jan 1, 2020

Updated description

Thanks, but new description doesn't make it clear. Could you provide exact warning your are trying to fix, please?

@s-kanaev
Copy link
Contributor Author

s-kanaev commented Jan 9, 2020

This warning:

CL/sycl/detail/type_list.hpp:34:13: warning: 'type_list' defined as a struct template here but previously declared as a class template; this is valid,  but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags]
template <> struct type_list<> {};

@bader bader changed the title [SYCL][NFC] Fix warning [SYCL][NFC] Fix a warning about mismatch tag in type_list declaration and definition Jan 9, 2020
@bader bader merged commit 44e1fd0 into intel:sycl Jan 9, 2020
vladimirlaz pushed a commit to vladimirlaz/llvm that referenced this pull request Apr 19, 2021
* Fix incorrect translation of FPGA decoration on arrays

var.annotation shall be emitted, but instead the translator was
generating ptr.annotation. It was happening due to incorrect assumption,
that for attributed static memory variable decoration shall be applied
to alloca instruction, whilst in the reality the alloca instruction
might be hidden by several cast instructions.

Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@ea6935b
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 20, 2021
* sycl: (625 commits)
  [SYCL] Fix post-commit build failure (intel#3578)
  [SYCL] Add support for set(get)_specialization_constant (intel#3501)
  [SYCL] Do not allow template instantiation to create null attributes. (intel#3575)
  [SYCL][PI][L0] Close and submit batch immediately when Queue is empty. (intel#3552)
  [SYCL] Raise bit_cast to SYCL namespace (intel#3524)
  [ESIMD] Always preserve -vc-codegen option for ESIMD kernels (intel#3547)
  [SYCL] Fix warnings on clang-based build (intel#3570)
  Revert "Align tests with the codegen changes"
  Disable SPV_INTEL_memory_access_aliasing extension
  Fix build issues after applying translator patches
  [PassManager][PhaseOrdering] lower expects before running simplifyCFG
  Exclude spirv.hpp for clang-format
  Fix llvm-spirv crash when count of Fortran metadata variables is an array
  Fix transTypeComposite bug (intel#964)
  Fix incorrect translation of FPGA decoration on arrays (intel#983)
  Tolerate more inputs during alias.scope/noalias MD translation (intel#994)
  Update for LLVM iterator change
  Fix crash at translation of Entity of DebugImportedEntity (intel#951)
  Add HandleLLVMOptions to main CMakeLists.txt to propagate configuration flags. In particular, this enables Multi-threaded option in MSVC (instead of Multi-threaded DLL)
  Fix uninitialized variables warnings These warnings come into place when HandleLLVMOptions is imported
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants