Skip to content

[SYCL] Switch SPIR-V offload target to opaque pointers #9828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 8, 2023
Merged

[SYCL] Switch SPIR-V offload target to opaque pointers #9828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6b9def8
[SYCL] Run SYCL end-to-end with opaque pointers
bader Jun 12, 2023
27bcd54
Disable more failing LIT test.
bader Jun 12, 2023
3ced019
Merge remote-tracking branch 'intel/sycl' into test-e2e-opaque
bader Jun 15, 2023
b1ed1d6
Disable matrix tests.
bader Jun 15, 2023
85ecd5c
Re-enable fixed tests.
bader Jun 15, 2023
696e060
Merge remote-tracking branch 'intel/sycl' into test-e2e-opaque
bader Jul 21, 2023
1bc4b1a
Revert unnecessary changes.
bader Jul 21, 2023
10e11ae
Merge remote-tracking branch 'intel/sycl' into test-e2e-opaque
bader Jul 27, 2023
4a3baa1
Merge remote-tracking branch 'intel/sycl' into test-e2e-opaque
bader Aug 1, 2023
3f2084c
Fix/disable failing tests.
bader Aug 1, 2023
b5e9afb
Remove separate build configuration. It matches the default now.
bader Aug 1, 2023
e083f32
Disable tests failing due to lack of opaque pointers support.
bader Aug 2, 2023
a3db400
Revert nightly script changes to enable pre-commit tests.
bader Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,7 @@ set(DPCPP_ENABLE_OPAQUE_POINTERS TRUE CACHE BOOL
if (DPCPP_ENABLE_OPAQUE_POINTERS)
add_definitions("-DENABLE_OPAQUE_POINTERS=1")
endif(DPCPP_ENABLE_OPAQUE_POINTERS)
set(SPIRV_ENABLE_OPAQUE_POINTERS FALSE CACHE BOOL
set(SPIRV_ENABLE_OPAQUE_POINTERS TRUE CACHE BOOL
"Enable opaque pointers for SPIR-V offload by default.")
if(SPIRV_ENABLE_OPAQUE_POINTERS)
add_definitions("-DSPIRV_ENABLE_OPAQUE_POINTERS=1")
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/BFloat16/bfloat16_conversions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
// software emulation.
// UNSUPPORTED: accelerator

// FIXME: enable opaque pointers support on CPU.
// UNSUPPORTED: cpu

//==---------- bfloat16_conversions.cpp - SYCL bfloat16 type test ---------==//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
Expand Down
4 changes: 3 additions & 1 deletion sycl/test-e2e/BFloat16/bfloat16_type.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@

// TODO currently the feature isn't supported on FPGA.
// UNSUPPORTED: accelerator
//

// FIXME: enable opaque pointers support on CPU.
// UNSUPPORTED: cpu

//==----------- bfloat16_type.cpp - SYCL bfloat16 type test ----------------==//
//
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/DeviceLib/string_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
// RUN: %{build} -fno-builtin -fsycl-device-lib-jit-link -o %t.out
// RUN: %if !gpu %{ %{run} %t.out %}

// FIXME: enable opaque pointers support on CPU.
// UNSUPPORTED: cpu

#include <cassert>
#include <cstdint>
#include <cstring>
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/ESIMD/ext_math.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
// RUN: %{build} -fsycl-device-code-split=per_kernel %{mathflags} -o %t.out
// RUN: %{run} %t.out

// FIXME: enable opaque pointers support
// REQUIRES: TEMPORARY_DISABLED

// This test checks extended math operations. Combinations of
// - argument type - half, float
// - math function - sin, cos, ..., div_ieee, pow
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/KernelFusion/internalize_array_wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
// RUN: %{build} -fsycl-embed-ir -O2 -o %t.out
// RUN: %{run} %t.out

// FIXME: enable opaque pointers support
// REQUIRES: TEMPORARY_DISABLED

// Test internalization of a nested array type.

#include <array>
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/Reduction/reduction_usm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
// Windows doesn't yet have full shutdown().
// UNSUPPORTED: ze_debug && windows

// FIXME: enable opaque pointers support
// REQUIRES: TEMPORARY_DISABLED

// This test performs basic checks of parallel_for(nd_range, reduction, func)
// with reductions initialized with USM pointer.

Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/Regression/local-arg-align.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
//
// RUN: %{run} %t.out

// FIXME: enable opaque pointers support
// REQUIRES: TEMPORARY_DISABLED

//==-- local-arg-align.cpp - Test for local argument alignmnent ------------==//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
Expand Down