Skip to content

[SYCL][CUDA] Improve function to guess local work size more efficiently. #9787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 13, 2023
Merged

[SYCL][CUDA] Improve function to guess local work size more efficiently. #9787

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7944d20
Improve guessLocalWorkSize to avoid poor performance when having prim…
mmoadeli Jun 8, 2023
e8a53ed
Merge branch 'sycl' into guess-local-work-space
mmoadeli Jun 8, 2023
2962217
Address merge conflicts
mmoadeli Jun 8, 2023
d7f1e4c
Fix a mistake in comment.
mmoadeli Jun 8, 2023
c3939b8
Revert change to .gitignore.
mmoadeli Jun 8, 2023
3b3f7f8
Reverts removed comment.
mmoadeli Jun 8, 2023
073fd4a
Fix code style
mmoadeli Jun 8, 2023
b05428c
Merge branch 'intel:sycl' into guess-local-work-space
mmoadeli Jun 8, 2023
e3f8396
Add missing parantheses
mmoadeli Jun 8, 2023
e878744
Define isPrime a a lambda.
mmoadeli Jun 12, 2023
2bf6505
Update a variable name to a more descriptive one.
mmoadeli Jun 13, 2023
2b485cb
Update a variable name to a more descriptive one.
mmoadeli Jun 13, 2023
e39beee
Remove the need for computing square in for loop check in isPrime.
mmoadeli Jun 13, 2023
d00163a
Merge branch 'intel:sycl' into guess-local-work-space
mmoadeli Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing parantheses
  • Loading branch information
@mmoadeli
mmoadeli committed Jun 8, 2023
commit e3f83960beec5c57f41d1c19d97f78f17754e99f
4 changes: 2 additions & 2 deletions sycl/plugins/cuda/pi_cuda.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,8 +355,8 @@ void guessLocalWorkSize(_pi_device *device, size_t *threadsPerBlock,
// work group size to produce uniform work groups.
// Additionally, for best compute utilisation, the local size has
// to be a power of two.
while (0u != (x_global_work_size % threadsPerBlock[0]) ||
!isPowerOf2(threadsPerBlock[0]) {
while (0u != (x_global_work_size % threadsPerBlock[0]) ||
!isPowerOf2(threadsPerBlock[0])) {
--threadsPerBlock[0];
}
}
Expand Down