Skip to content

[SYCL][NFC] Remove llvm-no-spir-kernel tool #9710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2023
Merged

[SYCL][NFC] Remove llvm-no-spir-kernel tool #9710

merged 1 commit into from
Jun 13, 2023

Conversation

mdtoguchi
Copy link
Contributor

The llvm-no-spir-kernel tool is no longer in use. Remove the creation, tests and driver infrastructure to use the tool. Also remove the reference from the docs.

@mdtoguchi
[SYCL][NFC] Remove llvm-no-spir-kernel tool
ca557f6 
The llvm-no-spir-kernel tool is no longer in use.  Remove the creation,
tests and driver infrastructure to use the tool.  Also remove the
reference from the docs.
@mdtoguchi mdtoguchi requested review from a team as code owners June 1, 2023 21:59
@mdtoguchi mdtoguchi requested a review from sergey-semenov June 1, 2023 21:59
@mdtoguchi mdtoguchi temporarily deployed to aws June 2, 2023 02:31 — with GitHub Actions Inactive
@mdtoguchi mdtoguchi temporarily deployed to aws June 2, 2023 04:17 — with GitHub Actions Inactive
sarnex
sarnex approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hero

asudarsa
asudarsa approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the cleanup. One less tool to worry about.

@mdtoguchi
Copy link
Contributor Author

@intel/dpcpp-specification-reviewers, @intel/llvm-reviewers-runtime, @sergey-semenov, could you take a look? thanks!

steffenlarsen
steffenlarsen approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design docs LGTM!

@steffenlarsen steffenlarsen merged commit 36e6e06 into intel:sycl Jun 13, 2023
fineg74 pushed a commit to fineg74/llvm that referenced this pull request Jun 15, 2023
@mdtoguchi @fineg74
[SYCL][NFC] Remove llvm-no-spir-kernel tool (intel#9710)
4d78f13 
The llvm-no-spir-kernel tool is no longer in use. Remove the creation,
tests and driver infrastructure to use the tool. Also remove the
reference from the docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarnex sarnex sarnex approved these changes

@asudarsa asudarsa asudarsa approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@hchilama hchilama hchilama approved these changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov sergey-semenov is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mdtoguchi @sarnex @asudarsa @aelovikov-intel @steffenlarsen @hchilama