[SYCL][ABI Breaking] CG/handler refactoring to reduce boilerplate #9609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
requested review from
victor-eds,
Naghasan,
sommerlukas and
a team
as code owners
aelovikov-intel
force-pushed
the
refactor-cg
branch
from
a161d86 to
df464a3
Compare
aelovikov-intel
force-pushed
the
refactor-cg
branch
from
df464a3 to
18779af
Compare
aelovikov-intel
force-pushed
the
refactor-cg
branch
from
18779af to
ee28582
Compare
aelovikov-intel
force-pushed
the
refactor-cg
branch
from
ee28582 to
6b4c97e
Compare
aelovikov-intel
force-pushed
the
refactor-cg
branch
from
6b4c97e to
b59344c
Compare
steffenlarsen
approved these changes
May 30, 2023
sycl/include/sycl/detail/cg.hpp
Outdated
| MAccStorage(std::move(AccStorage)), | ||
| MSharedPtrStorage(std::move(SharedPtrStorage)), | ||
| MRequirements(std::move(Requirements)), MEvents(std::move(Events)) { | ||
| struct Data { |
There was a problem hiding this comment.
Nit; I'm not sold on the name. "Data" seems too general. Maybe something like CommonCGStorage?
sommerlukas
approved these changes
May 30, 2023
steffenlarsen
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.