Skip to content

[SYCL][Test E2E] Remove sycl_be/target_devices params support #9606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aelovikov-intel
Copy link
Contributor

sycl_devices is used instead now, including our public and internal CI.

sycl_devices is used instead now, including our public and internal CI.
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner May 25, 2023 15:02
@aelovikov-intel aelovikov-intel temporarily deployed to aws May 25, 2023 15:28 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel temporarily deployed to aws May 25, 2023 16:14 — with GitHub Actions Inactive
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

// Since we deprecate SYCL_BE and SYCL_DEVICE_TYPE,
is the last reference to SYCL_BE in our source code base, which we have to clean-up.
Thanks!

@aelovikov-intel
Copy link
Contributor Author

@KseniyaTikhomirova , @intel/llvm-reviewers-runtime , ping.

@aelovikov-intel aelovikov-intel merged commit 4e9ab7a into intel:sycl May 30, 2023
@aelovikov-intel aelovikov-intel deleted the remove-deprecated-params branch May 30, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants