[SYCL][PI] Fix PI_KERNEL_MAX_SUB_GROUP_SIZE query for devices without sub groups
#9543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub groups Change the fallback behavior for `PI_KERNEL_MAX_SUB_GROUP_SIZE` to return the maximum sub group size for the device, rather than the maximum work group size for the kernel, on devices where sub groups are not supported. This change makes it consistent with the result of the `PI_DEVICE_INFO_SUB_GROUP_SIZES_INTEL` query. Signed-off-by: Michael Aziz <michael.aziz@intel.com>
0x12CC
changed the title
PI_KERNEL_MAX_SUB_GROUP_SIZE query for devices without sub groupsPI_KERNEL_MAX_SUB_GROUP_SIZE query for devices without sub groups
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
|
Could you add comments in the code explaining why we need two calls to PI? I understand it's one to get the size and one to get the elements, correct me if I'm wrong. |
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the fallback behavior for
PI_KERNEL_MAX_SUB_GROUP_SIZEto return the maximum sub group size for the device, rather than the maximum work group size for the kernel, on devices where sub groups are not supported. This change makes it consistent with the result of thePI_DEVICE_INFO_SUB_GROUP_SIZES_INTELquery.