Skip to content

[SYCL][Matrix] Fix TK size for tf32 test case. #9531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2023
Merged

[SYCL][Matrix] Fix TK size for tf32 test case. #9531

merged 1 commit into from
May 30, 2023

Conversation

arnamoy10
Copy link
Contributor

@arnamoy10 arnamoy10 commented May 19, 2023 •
edited
Loading

This small patch fixes the TK size for tf32 type.

@arnamoy10 arnamoy10 requested a review from dkhaldi May 19, 2023 14:29
@arnamoy10 arnamoy10 self-assigned this May 19, 2023
@arnamoy10 arnamoy10 requested a review from a team as a code owner May 19, 2023 14:29
@arnamoy10 arnamoy10 requested a review from aelovikov-intel May 19, 2023 14:29
@arnamoy10 arnamoy10 temporarily deployed to aws May 19, 2023 14:55 — with GitHub Actions Inactive
@arnamoy10 arnamoy10 temporarily deployed to aws May 19, 2023 15:26 — with GitHub Actions Inactive
@arnamoy10 arnamoy10 temporarily deployed to aws May 19, 2023 19:18 — with GitHub Actions Inactive
@arnamoy10 arnamoy10 temporarily deployed to aws May 19, 2023 20:00 — with GitHub Actions Inactive
dkhaldi
dkhaldi requested changes May 19, 2023
View reviewed changes
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include correction to https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/Matrix/joint_matrix_tf32_impl.hpp as well as part of this PR.
I think these two are the only tf32 tests right?

@arnamoy10
Copy link
Contributor Author

Include correction to https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/Matrix/joint_matrix_tf32_impl.hpp as well as part of this PR. I think these two are the only tf32 tests right?

Done

@arnamoy10 arnamoy10 temporarily deployed to aws May 30, 2023 12:54 — with GitHub Actions Inactive
dkhaldi
dkhaldi approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnamoy10 arnamoy10 temporarily deployed to aws May 30, 2023 13:44 — with GitHub Actions Inactive
@arnamoy10
Copy link
Contributor Author

@steffenlarsen Help merge please?

@steffenlarsen
Copy link
Contributor

Timed Out Tests (1):
SYCL :: DeviceGlobal/device_global_device_image_scope_unused.cpp - Reported in #9456

@steffenlarsen steffenlarsen merged commit 9562eb3 into intel:sycl May 30, 2023
@arnamoy10 arnamoy10 deleted the tf32_test_fix branch May 30, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhaldi dkhaldi dkhaldi approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@aelovikov-intel aelovikov-intel Awaiting requested review from aelovikov-intel aelovikov-intel was automatically assigned from intel/llvm-reviewers-runtime

@YuriPlyakhin YuriPlyakhin Awaiting requested review from YuriPlyakhin

@yubingex007-a11y yubingex007-a11y Awaiting requested review from yubingex007-a11y

Assignees

@arnamoy10 arnamoy10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnamoy10 @steffenlarsen @dkhaldi