Skip to content

[SYCL] Enable improved code location for SYCL extensions #9360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2023
Merged

[SYCL] Enable improved code location for SYCL extensions #9360

merged 1 commit into from
May 9, 2023

Conversation

reble
Copy link
Contributor

@reble reble commented May 8, 2023

This patch enables an improved code location for vendor specific extensions nested inside the sycl namespace, i. e. ext::oneapi::experimental.

@reble reble requested a review from a team as a code owner May 8, 2023 21:23
@reble reble requested a review from sergey-semenov May 8, 2023 21:23
@reble reble temporarily deployed to aws May 8, 2023 22:15 — with GitHub Actions Inactive
@reble reble temporarily deployed to aws May 9, 2023 00:44 — with GitHub Actions Inactive
aelovikov-intel
aelovikov-intel approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's related to #8721, is that right?

@reble
Copy link
Contributor Author

reble commented May 9, 2023

I think it's related to #8721, is that right?

Yes it's related.
Thanks for pointing that out, wasn't aware of this PR. But looks like we came to the same conclusion solving the issue.
Found it when working on #7627

@aelovikov-intel
Copy link
Contributor

CUDA's

Unexpectedly Passed Tests (1):
  SYCL :: KernelFusion/device_info_descriptor.cpp

is unrelated.

@aelovikov-intel aelovikov-intel merged commit 4d73490 into intel:sycl May 9, 2023
@reble reble mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov sergey-semenov is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reble @aelovikov-intel