[SYCL][E2E] Disable flaky test on Windows #9290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally I wanted to disable this on Gen12 Windows only, but it seems there are a ton of device IDs we would need to check and based on intel#9117 (comment) we don't care about Windows anyway. Related: intel#9117 Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
sergey-semenov
approved these changes
May 3, 2023
|
Yes, use of immediate command lists, and therefore this test, can be disabled on all GPUs when running on Windows. |
|
@intel/llvm-gatekeepers I think we are good to merge, we shouldn't need CI to finish if you look at the change, the test author supports the change (see above), and many people are hitting this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I wanted to disable this on Gen12 Windows only, but it seems there are a ton of device IDs we would need to check and based on #9117 (comment) we don't care about Windows anyway.
Related: #9117