[SYCL][Doc] Add draft of sycl_ext_oneapi_prefetch #9282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds prefetch and joint_prefetch functions for providing prefetch hints associated with specific levels of cache. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Pennycook
added
the
spec extension
Prefetching into the lowest level of cache is consistent with the behavior of other prefetch extensions. On some hardware, prefetching into the lowest level of cache will populate all levels of cache, and many developers may expect this to be the default behavior.
Allows for additional information to be specified alongside a level of cache. The current proposal provides only a "nontemporal" hint that could be meaningful on multiple devices; additional extensions could define their own hints (e.g. pvc::uncached).
|
One open question for reviewers: Does it make sense to have The former is nice from a readability perspective, because "L1" is clearly a level of cache, whereas "1" could be anything. But the latter is nice from a verbosity perspective, because |
spencerpatty
reviewed
May 8, 2023
spencerpatty
reviewed
May 8, 2023
gmlueck
reviewed
May 18, 2023
Use accessor<> directly and limit the TargetMode to target::device.
gmlueck
reviewed
May 22, 2023
gmlueck
approved these changes
May 22, 2023
|
@bader - I think this can be merged, now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds prefetch and joint_prefetch functions for providing prefetch hints associated with specific levels of cache.