-
Notifications
You must be signed in to change notification settings - Fork 772
[SYCL][E2E test] Add -fno-fast-math to math tests that relies on it #9135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Do we need here as well? https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/Basic/built-ins/marray_math.cpp |
for now, we have seen failures due to fast-math enabled on some specific tests. I would suggest to adapt tests one by one if we really see the difference in this option being enabled and disabled. |
Sounds good to me. Just FYI, these math build-in overloads with support of marray call scalar math built-ins inside them. The test for scalar math built-ins was modified in this PR. |
thanks for highlighting it! I will double check to confirm if marray test could fail as well. |
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
@intel/llvm-gatekeepers hello, this PR is ready for merge. |
No description provided.