Skip to content

[SYCL][E2E test] Add -fno-fast-math to math tests that relies on it #9135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 3, 2023

Conversation

KseniyaTikhomirova
Copy link
Contributor

No description provided.

Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
@KseniyaTikhomirova KseniyaTikhomirova requested a review from a team as a code owner April 20, 2023 12:33
@dm-vodopyanov
Copy link
Contributor

@KseniyaTikhomirova
Copy link
Contributor Author

KseniyaTikhomirova commented Apr 20, 2023

Do we need here as well? https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/Basic/built-ins/marray_math.cpp

for now, we have seen failures due to fast-math enabled on some specific tests. I would suggest to adapt tests one by one if we really see the difference in this option being enabled and disabled.

@dm-vodopyanov
Copy link
Contributor

Do we need here as well? https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/Basic/built-ins/marray_math.cpp

for now, we have seen failures due to fast-math enabled on some specific tests. I would suggest to adapt tests one by one if we really see the difference in this option being enabled and disabled.

Sounds good to me. Just FYI, these math build-in overloads with support of marray call scalar math built-ins inside them. The test for scalar math built-ins was modified in this PR.

@KseniyaTikhomirova
Copy link
Contributor Author

Do we need here as well? https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/Basic/built-ins/marray_math.cpp

for now, we have seen failures due to fast-math enabled on some specific tests. I would suggest to adapt tests one by one if we really see the difference in this option being enabled and disabled.

Sounds good to me. Just FYI, these math build-in overloads with support of marray call scalar math built-ins inside them. The test for scalar math built-ins was modified in this PR.

thanks for highlighting it! I will double check to confirm if marray test could fail as well.

@KseniyaTikhomirova KseniyaTikhomirova temporarily deployed to aws April 20, 2023 12:59 — with GitHub Actions Inactive
@KseniyaTikhomirova KseniyaTikhomirova temporarily deployed to aws April 20, 2023 14:08 — with GitHub Actions Inactive
@KseniyaTikhomirova KseniyaTikhomirova changed the title [SYCL][E2E test] Add -fno-fast-math to math tests that relies on it ON HOLD PLEASE [SYCL][E2E test] Add -fno-fast-math to math tests that relies on it Apr 20, 2023
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
@KseniyaTikhomirova KseniyaTikhomirova temporarily deployed to aws April 21, 2023 11:54 — with GitHub Actions Inactive
@KseniyaTikhomirova KseniyaTikhomirova temporarily deployed to aws April 21, 2023 12:54 — with GitHub Actions Inactive
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
@KseniyaTikhomirova KseniyaTikhomirova changed the title ON HOLD PLEASE [SYCL][E2E test] Add -fno-fast-math to math tests that relies on it [SYCL][E2E test] Add -fno-fast-math to math tests that relies on it Apr 28, 2023
@KseniyaTikhomirova KseniyaTikhomirova temporarily deployed to aws April 28, 2023 09:52 — with GitHub Actions Inactive
@KseniyaTikhomirova KseniyaTikhomirova temporarily deployed to aws April 28, 2023 11:25 — with GitHub Actions Inactive
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
@KseniyaTikhomirova KseniyaTikhomirova temporarily deployed to aws May 3, 2023 10:34 — with GitHub Actions Inactive
@KseniyaTikhomirova KseniyaTikhomirova temporarily deployed to aws May 3, 2023 12:35 — with GitHub Actions Inactive
@KseniyaTikhomirova
Copy link
Contributor Author

@intel/llvm-gatekeepers hello, this PR is ready for merge.

@steffenlarsen steffenlarsen merged commit 25e86bd into intel:sycl May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants