[CI] Resolve artifacts name collision in Nightly #8926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightly job builds two flavors of containers: Ubuntu 20.04 and Ubuntu 22.04. Both flavors use the same name for build artifacts "default". When artifacts built on Ubuntu 22.04 packaged to Ubuntu 20.04 based image, the compiler doesn't work becuase C++ runtime is too old.
| @@ -34,7 +34,7 @@ jobs: | |||
| secrets: inherit | |||
| with: | |||
| build_cache_root: "/__w/" | |||
| build_artifact_suffix: default | |||
| build_artifact_suffix: default-2204 | |||
There was a problem hiding this comment.
I have a slight preference to
Suggested change
| build_artifact_suffix: default-2204 | |
| build_artifact_suffix: ubuntu2204 |
to align with the step's name, but that is subjective.
There was a problem hiding this comment.
"default" here means build configuration. In addition to "default" we have "no-assert" build and "self-build".
There was a problem hiding this comment.
to align with the step's name, but that is subjective.
We are going to drop ubuntu2004 steps in #7671.
aelovikov-intel
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly job builds two flavors of containers: Ubuntu 20.04 and Ubuntu
22.04. Both flavors use the same name for build artifacts "default".
When artifacts built on Ubuntu 22.04 packaged to Ubuntu 20.04 based
image, the compiler doesn't work becuase C++ runtime is too old.