Rename ConvertFToTF32INTEL to RoundFToTF32INTEL #8846
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extension name will be preserved for a while for binary compatibility. There is not public spec change yet, but it has to be done ASAP Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
asudarsa
reviewed
Mar 31, 2023
| @@ -101,6 +101,7 @@ enum InternalCapability { | |||
| ICapFPArithmeticFenceINTEL = 6144, | |||
| ICapGlobalVariableDecorationsINTEL = 6146, | |||
| ICapabilityComplexFloatMulDivINTEL = 6414, | |||
| ICapabilityTensorFloat32RoundingINTEL = 6425, | |||
| ICapabilityTensorFloat32ConversionINTEL = 6425, | |||
There was a problem hiding this comment.
will the two enums having same value cause issues here in expected behavior? Also, may be a TODO here? Thanks
There was a problem hiding this comment.
oh, it's a cherry-pick mistake
asudarsa
approved these changes
Mar 31, 2023
|
Probably we don't need this patch ASAP here, @dkhaldi please confirm |
|
Closing as we don't need it here ASAP and can wait for the pulldown |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension name will be preserved for a while for binary compatibility.
There is not public spec change yet, but it has to be done ASAP
It's a cherry-pick of KhronosGroup/SPIRV-LLVM-Translator#1913