[SYCL] Do not track allocation if we don't own the handle #8792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3344,7 +3344,7 @@ pi_result piextMemCreateWithNativeHandle(pi_native_handle NativeHandle, | |||
| pi_platform Plt = Context->getPlatform(); | |||
| std::unique_lock<pi_shared_mutex> ContextsLock(Plt->ContextsMutex, | |||
| std::defer_lock); | |||
| if (IndirectAccessTrackingEnabled) { | |||
| if (IndirectAccessTrackingEnabled && ownNativeHandle) { | |||
There was a problem hiding this comment.
Please add a source code comment why we check the ownership
There was a problem hiding this comment.
Added source code comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't own level zero handle of the pi_mem then we can't control deallocation of that memory so there is no point of keeping track of the memory allocation for deferred memory release. More over currently level zero context is leaked because we increase its ref count at the point where we start tracking memory but don't decrement that ref count in USMFreeHelper. This PR fixes that problem.