[Driver][SYCL] Allow undefined symbols when doing host deps generation #8743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation When processing archives when performing offload, the driver will perform a host link which generates a file that is used to determine any offload dependencies. This additional link step is just for gathering the dependency information and shouldn't require the full ability to link. Under some circumstances, for example generating an early or final image archive for FPGA, the symbol resolution is not important. Add a general case of -z undefs during this internal link step and allow the final host link to determine any unresolved symbols at that time.
hchilama
approved these changes
Mar 23, 2023
bader
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing archives when performing offload, the driver will perform a host link which generates a file that is used to determine any offload dependencies. This additional link step is just for gathering the dependency information and shouldn't require the full ability to link.
Under some circumstances, for example generating an early or final image archive for FPGA, the symbol resolution is not important. Add a general case of -z undefs during this internal link step and allow the final host link to determine any unresolved symbols at that time.