Skip to content

[SYCL][ESIMD] Don't add RegisterAllocMode metadata for ESIMD kernels #8698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2023
Merged

[SYCL][ESIMD] Don't add RegisterAllocMode metadata for ESIMD kernels #8698

merged 1 commit into from
Mar 22, 2023

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Mar 20, 2023

This works around a VC issue.

@sarnex sarnex temporarily deployed to aws March 20, 2023 17:08 — with GitHub Actions Inactive
@sarnex sarnex requested a review from a team March 20, 2023 17:13
@sarnex sarnex marked this pull request as ready for review March 20, 2023 17:13
@sarnex sarnex requested a review from a team as a code owner March 20, 2023 17:13
MrSidims
MrSidims approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is LGTM, but I don't understand the issue beneath it. Is RegisterAllocMode only for scalar compiler?

@sarnex
Copy link
Contributor Author

sarnex commented Mar 21, 2023

The code is LGTM, but I don't understand the issue beneath it. Is RegisterAllocMode only for scalar compiler?

Yes, exactly. I'll forward you the internal issue tracker if you are interested.

@sarnex
[SYCL][ESIMD] Don't add RegisterAllocMode metadata for ESIMD kernels
be96ea6 
This works around a VC issue.

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex temporarily deployed to aws March 21, 2023 22:35 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to aws March 22, 2023 02:31 — with GitHub Actions Inactive
@bader bader merged commit cfcba11 into intel:sycl Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@MrSidims MrSidims MrSidims approved these changes

@v-klochkov v-klochkov v-klochkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sarnex @AlexeySachkov @MrSidims @v-klochkov @bader