Skip to content

[SYCL] Fix dumping of images for multiple targets #8640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 22, 2023
Merged

[SYCL] Fix dumping of images for multiple targets #8640

merged 4 commits into from
Mar 22, 2023

Conversation

jchlanda
Copy link
Contributor

This was identified by the Unified Runtime team, depending on the target order in -fsycl-targets certain binaries are not dumped.

-fsycl-targets=nvptx64-nvidia-cuda,spir64

├── sycl_nvptx641.bin
├── sycl_spir642.spv
└── sycl_spir643.spv

-fsycl-targets=spir64,nvptx64-nvidia-cuda

├── sycl_spir641.spv
├── sycl_spir642.spv
└── sycl_spir643.spv

This patch makes sure that if a kernel is compiled for multiple targets, images belonging to different targets will be dumped.

@jchlanda jchlanda requested a review from a team as a code owner March 14, 2023 13:19
@jchlanda jchlanda requested a review from cperkinsintel March 14, 2023 13:19
@jchlanda jchlanda temporarily deployed to aws March 14, 2023 13:49 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to aws March 14, 2023 14:22 — with GitHub Actions Inactive
@jchlanda jchlanda force-pushed the jakub/dump_image_fix branch from bf3a74d to 08d2815 Compare March 15, 2023 09:30
@jchlanda jchlanda temporarily deployed to aws March 15, 2023 09:56 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to aws March 15, 2023 10:25 — with GitHub Actions Inactive
@jchlanda
Copy link
Contributor Author

Friendly ping @intel/llvm-reviewers-runtime

steffenlarsen
steffenlarsen approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small question.

@jchlanda jchlanda temporarily deployed to aws March 22, 2023 14:53 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to aws March 22, 2023 16:53 — with GitHub Actions Inactive
@bader bader merged commit 637cb85 into intel:sycl Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel cperkinsintel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchlanda @steffenlarsen @bader