[SYCL][L0] Disable native 2D USM memcpy by default #8609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a bug in memcpy 2D to and from non-USM pointers in the L0 native region memcpy make L0 report support for this operations based on a new SYCL_PI_LEVEL_ZERO_USE_NATIVE_USM_MEMCPY2D which defaults to disabled. Once the bug is fixed, this new environment variable should either be removed or enabled by default. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
/verify with intel/llvm-test-suite#1597 |
AlexeySachkov
approved these changes
Mar 10, 2023
|
@intel/dpcpp-l0-pi-reviewers - Friendly ping. |
smaslov-intel
approved these changes
Mar 14, 2023
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Jun 19, 2023
intel#8609 disabled the use of native memcpy2d backend calls in the L0 plugin due to a bug for non-USM pointers. This commit reenables it. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in memcpy 2D to and from non-USM pointers in the L0 native region memcpy make L0 report support for this operations based on a new
SYCL_PI_LEVEL_ZERO_USE_NATIVE_USM_MEMCPY2Dwhich defaults to disabled. Once the bug is fixed, this new environment variable should either be removed or enabled by default.