Skip to content

[SYCL] Revert any and all return types to int for vectors #8591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

steffenlarsen
Copy link
Contributor

SYCL 2020 has any and all return bool for scalar and marray arguments, but int for vector arguments. Currently enabling
SYCL2020_CONFORMANT_APIS switches all versions of any and all to return bool. This commit changes it so that the variants taking vector arguments are unaffected by SYCL2020_CONFORMANT_APIS and language version.

SYCL 2020 has any and all return bool for scalar and marray arguments,
but int for vector arguments. Currently enabling
SYCL2020_CONFORMANT_APIS switches all versions of any and all to return
bool. This commit changes it so that the variants taking vector
arguments are unaffected by SYCL2020_CONFORMANT_APIS and language
version.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen requested a review from a team as a code owner March 9, 2023 15:07
@steffenlarsen steffenlarsen requested a review from bso-intel March 9, 2023 15:07
@steffenlarsen steffenlarsen temporarily deployed to aws March 9, 2023 15:36 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 9, 2023 16:06 — with GitHub Actions Inactive
@AlexeySachkov AlexeySachkov requested a review from a team March 16, 2023 09:20
Copy link
Contributor

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steffenlarsen steffenlarsen merged commit ea26922 into intel:sycl Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants