-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL]Allow parameter pack expansion in device_has attribute #8536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adding @AaronBallman to check if he can suggest some other variants for testing pack expansion.
Hello, thank you for the update! At what compiler build |
I would be happy to add additional tests if there are any but this patch essentially just uses existing TableGen interface for pack expansion arguments. So most likely whatever currently works for other attributes which accept pack expansions will work here and if something does not work, it probably warrants follow-up work beyond the scope of this PR. |
@Alexander-Kleymenov I will reach out to you via email! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well; I don't think there's a need for additional pack expansion testing as part of this patch (I think the coverage is reasonable enough through other attributes, this is just extending the list of attributes using the functionality).
Thanks for the reviews everyone! @intel/llvm-gatekeepers PR is ready for merge. The failing testing looks infrastructure related. |
This is a known issue on CUDA. ESIMD emulator tests passed, but the job reported failure to upload some results somewhere, so it should be ok to merge anyway |
No description provided.