Skip to content

[SYCL]Allow parameter pack expansion in device_has attribute #8536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

elizabethandrews
Copy link
Contributor

No description provided.

@elizabethandrews elizabethandrews requested a review from a team as a code owner March 3, 2023 19:19
@elizabethandrews elizabethandrews temporarily deployed to aws March 3, 2023 20:37 — with GitHub Actions Inactive
@elizabethandrews elizabethandrews temporarily deployed to aws March 3, 2023 21:26 — with GitHub Actions Inactive
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Adding @AaronBallman to check if he can suggest some other variants for testing pack expansion.

@Alexander-Kleymenov
Copy link

Hello, thank you for the update! At what compiler build device_has support for variadic args will be available?

@elizabethandrews
Copy link
Contributor Author

LGTM!

Adding @AaronBallman to check if he can suggest some other variants for testing pack expansion.

I would be happy to add additional tests if there are any but this patch essentially just uses existing TableGen interface for pack expansion arguments. So most likely whatever currently works for other attributes which accept pack expansions will work here and if something does not work, it probably warrants follow-up work beyond the scope of this PR.

@elizabethandrews
Copy link
Contributor Author

Hello, thank you for the update! At what compiler build device_has support for variadic args will be available?

@Alexander-Kleymenov I will reach out to you via email!

Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well; I don't think there's a need for additional pack expansion testing as part of this patch (I think the coverage is reasonable enough through other attributes, this is just extending the list of attributes using the functionality).

@elizabethandrews
Copy link
Contributor Author

Thanks for the reviews everyone!

@intel/llvm-gatekeepers PR is ready for merge. The failing testing looks infrastructure related.

@AlexeySachkov
Copy link
Contributor

  Failed Tests (1):
    SYCL :: SubGroup/shuffle_fp64.cpp

This is a known issue on CUDA. ESIMD emulator tests passed, but the job reported failure to upload some results somewhere, so it should be ok to merge anyway

@AlexeySachkov AlexeySachkov merged commit ecc3bc6 into intel:sycl Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants