Skip to content

[NFC][SYCL] Refactor ConvertToOpenCLType_t #8507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2023
Merged

[NFC][SYCL] Refactor ConvertToOpenCLType_t #8507

merged 2 commits into from
Mar 7, 2023

Conversation

aelovikov-intel
Copy link
Contributor

Use a helper type to avoid code duplication and make logic clearer to the reader.

@aelovikov-intel
[NFC][SYCL] Refactor ConvertToOpenCLType_t
560a104 
Use a helper type to avoid code duplication and make logic clearer to
the reader.
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner March 1, 2023 20:21
@aelovikov-intel aelovikov-intel temporarily deployed to aws March 2, 2023 01:53 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel temporarily deployed to aws March 2, 2023 03:00 — with GitHub Actions Inactive
steffenlarsen
steffenlarsen approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aelovikov-intel aelovikov-intel temporarily deployed to aws March 2, 2023 17:54 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel temporarily deployed to aws March 4, 2023 12:24 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel temporarily deployed to aws March 7, 2023 09:32 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel temporarily deployed to aws March 7, 2023 10:32 — with GitHub Actions Inactive
@steffenlarsen
Copy link
Contributor

HIP Timed Out Tests (4):
SYCL :: KernelAndProgram/spec_constants_after_link.cpp
SYCL :: Regression/kernel_bundle_ignore_sycl_external.cpp
SYCL :: Regression/same_unnamed_kernels.cpp
SYCL :: Regression/static-buffer-dtor.cpp
These are currently not supported on HIP and are marked unsupported in intel/llvm-test-suite#1639.

HIP Unresolved Tests (1):
SYCL :: AsyncHandler/default_async_handler.cpp
Reported in #8555.

@steffenlarsen steffenlarsen merged commit e87b456 into intel:sycl Mar 7, 2023
@aelovikov-intel aelovikov-intel deleted the refactor_convert_to_ocl branch April 7, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aelovikov-intel @steffenlarsen