-
Notifications
You must be signed in to change notification settings - Fork 797
[SYCL] Add size_type, to accessor and local_accessor classes. #8379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
2503a62
Diagnostic for const qualified DataT with non read-only accessor
mmoadeli 862b688
Merge branch 'sycl' of https://github.com/mmoadeli/llvm into sycl
mmoadeli 1edb94f
Add test for const qualified DataT with non readonly accessor.
mmoadeli 7ba64c6
Assign valid access mode for local accessor, depending on the type of…
mmoadeli ef0038e
Minor test update.
mmoadeli 36971f8
- Rename AccessMode to AccessModeFromConstness
mmoadeli 29e3036
- Revert test to be without -Xclang -verify.
mmoadeli 92debe8
Refactors implementation of diagnostic to avoid compiler errors due t…
mmoadeli 7eac372
Updates the test to use -Xclang -verify
mmoadeli dcac706
Fix style-checl
mmoadeli 9d4b313
Merge branch 'intel:sycl' into sycl
mmoadeli ad92330
Merge branch 'intel:sycl' into sycl
mmoadeli 45edd05
Add size_type in host_accessor.
mmoadeli 8e52469
Add value_type, reference and const_reference to host_accessor.
mmoadeli c7d3887
Add size_type to accessor and local_accessor classes.
mmoadeli 7030585
Replace size_type with size_t according to specification.
mmoadeli 45825d8
Add test for checking size_type in accessors.
mmoadeli ee42a0a
Remove newly defined aliases from the host_accessor as they are alrea…
mmoadeli 635012b
Remove the need to run the test.
mmoadeli f78a556
Re-define size_type using std::size_t.
mmoadeli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out | ||
// RUN: %t.out | ||
|
||
#include <sycl/sycl.hpp> | ||
#include <type_traits> | ||
|
||
int main() { | ||
using accessor_size_type = sycl::accessor<int, 3>::size_type; | ||
using local_accessor_size_type = sycl::local_accessor<int, 3>::size_type; | ||
using host_accessor_size_type = sycl::host_accessor<int, 3>::size_type; | ||
|
||
static_assert(std::is_same_v<accessor_size_type, size_t>); | ||
static_assert(std::is_same_v<local_accessor_size_type, size_t>); | ||
static_assert(std::is_same_v<host_accessor_size_type, size_t>); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.