[SYCL] Fix handling of host-side memory in 2D memops #8359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of 2D USM memory operations will launch a kernel as a fallback mechanism. However, these interfaces are also intended to accept pointers USM and non-USM host memory. To allow this, the implementation now picks different fallback mechanisms depending on the type of pointer passed. For fill/memset this means: 1. Always use backend-defined interface if available. 2. Use auxiliary fill kernel if pointer is to device memory. 3. Use a host-task with a fill per row if the pointer is to host memory. For memcpy/copy this means: 1. Always use backend-defined interface if available. 2. Use auxiliary copy kernel if both pointers are to device memory. 3. Use a host-task with a copy per row if both pointer are to host memory. 4. Enqueue a USM memcpy per row if one pointer is to in host memory and the other pointer is in device memory. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
/verify with intel/llvm-test-suite#1597 |
|
/verify with intel/llvm-test-suite#1597 |
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
/verify with intel/llvm-test-suite#1597 |
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
/verify with intel/llvm-test-suite#1597 |
|
@intel/llvm-reviewers-runtime - Friendly ping. |
dm-vodopyanov
approved these changes
Mar 6, 2023
|
@steffenlarsen there is ABI test failure on Windows: https://github.com/intel/llvm/actions/runs/4344793318/jobs/7588612300, can you please take a look? |
Thank you, @dm-vodopyanov ! Fixed in #8547. |
|
|
||
| // Do the following: | ||
| // 1. If both are host, use host_task to copy. | ||
| // 2. If either pointer is host or of the backend supports native memcpy2d, |
There was a problem hiding this comment.
Typo: "or OF the backend"
There was a problem hiding this comment.
Fixed in #8553.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of 2D USM memory operations will launch a kernel as a fallback mechanism. However, these interfaces are also intended to accept pointers to USM and non-USM host memory. To allow this, the implementation now picks different fallback mechanisms depending on the type of pointer passed.
For fill/memset this means:
For memcpy/copy this means: