[SYCL] Add 'cl::sycl::intel::experimental::printf' #835
Conversation
|
Another approach for the changes in clang: #909 |
AlexeySachkov
force-pushed
the
private/asachkov/printf
branch
from
f91daff to
52372fd
Compare
AlexeySachkov
changed the title
AlexeySachkov
force-pushed
the
private/asachkov/printf
branch
from
52372fd to
198bce3
Compare
AlexeySachkov
force-pushed
the
private/asachkov/printf
branch
3 times, most recently
from
29a9b9c to
85bc165
Compare
| // appear in different order if output is redirected to a file or | ||
| // another app | ||
| // FIXME: strictly check output order once the bug is fixed | ||
| // CHECK: {{(Hello, World!)?}} |
There was a problem hiding this comment.
This is fragile, even for a workaround. I hope this bug is stable
enough.
There was a problem hiding this comment.
From local runs it seems that it is stable enough, yes
AlexeySachkov
force-pushed
the
private/asachkov/printf
branch
from
85bc165 to
5f245ca
Compare
| @@ -0,0 +1,70 @@ | |||
| //==------ builtins.hpp - Non-standard SYCL built-in functions -------------==// | |||
There was a problem hiding this comment.
Rather than non-standard, there are mostly Intel extensions, aren't they?
There was a problem hiding this comment.
Hmm, at this point I would say it mostly "non-standard" rather than actual Intel extensions, since this file is only contains experimental::printf which doesn't have special extension document
AlexeySachkov
force-pushed
the
private/asachkov/printf
branch
from
5f245ca to
e18f7ff
Compare
| // - You can print vector data types using 'v' modifier: | ||
| // #ifdef __SYCL_DEVICE_ONLY__ // this is only available on real devices | ||
| // auto vec = cl::sycl::vec<int, 8> v(1, 2, 3, 4, 5, 6, 7, 8); | ||
| // using ocl_vec_type = cl::sycl::vec<int, 8>::vector_t; |
There was a problem hiding this comment.
And if I have cl::sycl::vec<long, 8> on Windows, I have to use %v8d instead of %v8ld, because long is 32bit there, right? We definitely need a correct format diagnostic here (not with this patch). Or maybe Clang can adjust a format string according to the OpenCL rules, since it is guaranteed to be a compile-time constant.
New built-in is mapped to OpenCL 'printf' built-in by using SPIR-V friendly IR. Signed-off-by: Alexey Sotkin <alexey.sotkin@intel.com> Co-authored-by: Alexey Sachkov <alexey.sachkov@intel.com>
AlexeySachkov
force-pushed
the
private/asachkov/printf
branch
from
e18f7ff to
1db211f
Compare
New built-in is mapped to OpenCL 'printf' built-in by using SPIR-V
friendly IR.