[SYCL] Implement get_multi_ptr for accessor and local_accessor #8249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mmoadeli
commented
Feb 8, 2023
mmoadeli
commented
- Implement get_multi_ptr for accessor and local_accessor
- Add test for get_multi_ptr
- Update the affected default ctor test
Update failing tests due to adding diagnostic for const qualified DataT only allowed for non readonly accessor.
- Use -Xclang -verify for testing
Having it requires handling over 20 expected-erros.
…o inheritance from base class hitting assert.
- Add test for get_multi_ptr - Update the affected defaut ctor test
- Update the affected test.
| @@ -0,0 +1,46 @@ | |||
| // RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out | |||
There was a problem hiding this comment.
Suggested change
| // RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out | |
| // RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -fsyntax-only |
See some BKMs on tests: here
Since the test only contains a few static_asserts which do most of the actual checking, I would also suggest to maybe refactor the test to significantly simplify it. We can turn everything into a single function, which accepts handler and buffer, creates accessors and then checks return types of methods.
There was a problem hiding this comment.
thanks @AlexeySachkov, done.
| // TODO: uncomment check with get_multi_ptr() when SYCL 2020 mupti_ptr feature | ||
| // will be merged | ||
| // assert(B.get_multi_ptr() == nullptr); | ||
| assert(B.get_multi_ptr<sycl::access::decorated::yes>() == nullptr); |
There was a problem hiding this comment.
For good measure, could you please add a sycl::access:decorated::no and sycl::access::decorated::legacy test case here?
There was a problem hiding this comment.
thanks @steffenlarsen , done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.