Skip to content

[SYCL] Fix test configurations when L0 and OpenCL are disabled #8247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2023

Conversation

steffenlarsen
Copy link
Contributor

This commit changes the configuration of in-tree SYCL LIT tests to include features for when the L0 and OpenCL plugins are enabled. This allows the interop backend tests to be split into backend-dependent tests to be run only when their backends are enabled. Additionally, this commit changes the fsycl-host-only LIT configuration replacement to ignore unset include paths, avoiding empty "-isystem" options when related backends are disabled.

This commit changes the configuration of in-tree SYCL LIT tests to
include features for when the L0 and OpenCL plugins are enabled. This
allows the interop backend tests to be split into backend-dependent
tests to be run only when their backends are enabled. Additionally,
this commit changes the fsycl-host-only LIT configuration replacement to
ignore unset include paths, avoiding empty "-isystem" options when
related backends are disabled.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen requested a review from a team as a code owner February 8, 2023 13:02
@steffenlarsen steffenlarsen temporarily deployed to aws February 8, 2023 14:22 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws February 9, 2023 05:19 — with GitHub Actions Inactive
Copy link
Contributor

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader
Copy link
Contributor

bader commented Mar 24, 2023

@steffenlarsen, please, resolve merge conflicts.

Do we have an option to disable OpenCL or Level Zero back-end? I thought these two are always enabled.

@steffenlarsen
Copy link
Contributor Author

Do we have an option to disable OpenCL or Level Zero back-end? I thought these two are always enabled.

In the general case our configuration scripts force them to be enabled, however there is nothing stopping you from specifying SYCL_ENABLE_PLUGINS yourself, in which case OpenCL and Level Zero are only enabled if they are in the list you provide.

@steffenlarsen steffenlarsen temporarily deployed to aws March 24, 2023 12:02 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 24, 2023 12:48 — with GitHub Actions Inactive
@bader
Copy link
Contributor

bader commented Mar 24, 2023

Failed Tests (1):
SYCL :: Basic/kernel_info.cpp

The issue is not related to the patch and this test was disabled by intel/llvm-test-suite@a592341.

@bader bader merged commit 2002dc0 into intel:sycl Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants