[SYCL][HIP] Adds support for PCI device id and UUID #8233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@npmiller If you can also comment. Wasn't able to choose additional reviewers |
|
It looks the macro are related to the compute capability and the ones used for the PR were related to the driver-version
…________________________________
From: zjin-lcf ***@***.***>
Sent: Thursday, February 16, 2023 10:52 AM
To: intel/llvm ***@***.***>
Cc: Bagusetty, Abhishek ***@***.***>; Mention ***@***.***>
Subject: Re: [intel/llvm] [SYCL][HIP] Adds support for PCI device id and UUID (PR #8233)
I have a question for @abagusetty<https://github.com/abagusetty> . Are these HIP macros related to the issue ROCm/ROCm#1907<ROCm/ROCm#1907> ?
—
Reply to this email directly, view it on GitHub<#8233 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOHFYYO7ASN4OUGGWE63DJDWXZLL3ANCNFSM6AAAAAAUUH3P7M>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
npmiller
approved these changes
Feb 17, 2023
|
@llvm-reviewers-runtime can I get help with review and merge |
|
Can I get some help with review and merge @intel/llvm-reviewers-runtime |
|
@intel/llvm-reviewers-runtime Friendly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the extensions for HIP.