Skip to content

Module leak #8153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 7, 2023
Merged

Module leak #8153

merged 7 commits into from
Mar 7, 2023

Conversation

bso-intel
Copy link
Contributor

@bso-intel bso-intel commented Jan 30, 2023 •
edited
Loading

When it is failed to build a program, L0 throws an exception, which causes sycl::program to fail to create.
Because of this, RT won't call piProgramRelease(), which leads to memory leaks.
The solution is to release ZeModule created by plugin when the program build is failed.

@bso-intel
[SYCL] Deallocate PiModule when program build failed
07538d1 
Currently, ZE_DEBG=4 test shows memory leak.
The reason is that we missed the zeModuleDestroy() call
when a program build failed.

Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel
guard
7d2702a 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel bso-intel temporarily deployed to aws January 30, 2023 19:26 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws January 31, 2023 02:24 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws January 31, 2023 02:52 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws January 31, 2023 02:54 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws January 31, 2023 02:59 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws January 31, 2023 03:00 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws January 31, 2023 03:03 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws January 31, 2023 03:05 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws January 31, 2023 03:58 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws January 31, 2023 04:30 — with GitHub Actions Inactive
@bso-intel
reset prt
9e482c6 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel bso-intel temporarily deployed to aws January 31, 2023 06:43 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws January 31, 2023 07:15 — with GitHub Actions Inactive
@bso-intel
keep buildlog
2bc2ed9 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel bso-intel temporarily deployed to aws January 31, 2023 23:26 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws January 31, 2023 23:59 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws February 1, 2023 00:06 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws February 1, 2023 00:08 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws February 1, 2023 00:49 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws February 1, 2023 07:00 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws February 2, 2023 17:49 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws February 4, 2023 12:24 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws February 5, 2023 03:24 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws February 5, 2023 09:29 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws February 14, 2023 18:22 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws February 14, 2023 18:24 — with GitHub Actions Inactive
@bso-intel bso-intel closed this Feb 17, 2023
@bso-intel bso-intel reopened this Feb 17, 2023
@bso-intel bso-intel temporarily deployed to aws February 18, 2023 00:18 — with GitHub Actions Inactive
@bader
Copy link
Contributor

bader commented Feb 18, 2023

@bso-intel, please, merge sycl to your branch. Re-start picks up CI scripts from the old state of the sycl branch, which unfortunately won't pass pre-commit.

@bso-intel bso-intel temporarily deployed to aws February 18, 2023 02:09 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws February 18, 2023 05:38 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws February 18, 2023 05:39 — with GitHub Actions Inactive
@bso-intel bso-intel marked this pull request as ready for review February 27, 2023 17:29
@bso-intel bso-intel requested a review from a team as a code owner February 27, 2023 17:29
@bso-intel bso-intel requested a review from againull February 28, 2023 19:19
@bso-intel
remove
aff946b 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel bso-intel temporarily deployed to aws March 1, 2023 01:04 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws March 2, 2023 12:24 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws March 2, 2023 21:21 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws March 4, 2023 12:24 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws March 4, 2023 22:30 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws March 4, 2023 23:13 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws March 4, 2023 23:50 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws March 4, 2023 23:51 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws March 5, 2023 08:47 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws March 6, 2023 04:51 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws March 6, 2023 05:41 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws March 6, 2023 06:23 — with GitHub Actions Inactive
@bso-intel
Copy link
Contributor Author

@againull
friendly ping

@againull againull merged commit 77866ff into intel:sycl Mar 7, 2023
@bso-intel bso-intel deleted the module-leak branch March 7, 2023 19:17
smaslov-intel
smaslov-intel reviewed Mar 29, 2023
View reviewed changes
sycl/plugins/level_zero/pi_level_zero.cpp
Program->State = _pi_program::Invalid;
Result = mapError(ZeResult);
if (Program->ZeBuildLog) {
ZE_CALL_NOCHECK(zeModuleBuildLogDestroy, (Program->ZeBuildLog));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bso-intel, @againull : this change causes a regression that build-log is destroyed before SYCL RT reads it (to report to the user). Please revert (or re-work) the patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaslov-intel smaslov-intel smaslov-intel left review comments

@againull againull againull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bso-intel @bader @againull @smaslov-intel