Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][ESIMD] Fix host compilation issue for atomic store #7823

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

fineg74
Copy link
Contributor

@fineg74 fineg74 commented Dec 16, 2022

This is to fix host compilation issue for lsc_atomic_update for store operation

@fineg74
Copy link
Contributor Author

fineg74 commented Dec 16, 2022

Complementary test PR intel/llvm-test-suite#1459

@fineg74
Copy link
Contributor Author

fineg74 commented Dec 16, 2022

/verify with intel/llvm-test-suite#1459

@againull
Copy link
Contributor

againull commented Jan 4, 2023

@fineg74 Could you please address CI failure, they seem related to the PR:
[2022-12-16T21:42:17.273Z] SYCL :: ESIMD/dword_atomic_cmpxchg.cpp
[2022-12-16T21:42:17.273Z] SYCL :: ESIMD/dword_atomic_smoke.cpp

@fineg74
Copy link
Contributor Author

fineg74 commented Jan 5, 2023

@fineg74 Could you please address CI failure, they seem related to the PR: [2022-12-16T21:42:17.273Z] SYCL :: ESIMD/dword_atomic_cmpxchg.cpp [2022-12-16T21:42:17.273Z] SYCL :: ESIMD/dword_atomic_smoke.cpp

Both tests pass in my environment with the fix, but I will take a look why it fails in CI

@fineg74
Copy link
Contributor Author

fineg74 commented Jan 6, 2023

/verify with intel/llvm-test-suite#1459

@fineg74
Copy link
Contributor Author

fineg74 commented Jan 6, 2023

Test failure for Windows:
SYCL :: SubGroupMask/Basic.cpp is not related to the change

@v-klochkov v-klochkov merged commit fdf8ac7 into intel:sycl Jan 6, 2023
@fineg74 fineg74 deleted the atomicLoadStore branch January 6, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants