Skip to content

Revert "[NFC][SYCL] Switch to std::enable_if (#7628)" #7779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

Fznamznon
Copy link
Contributor

This reverts commit 74833b2. We found issues when trying to build the project on RHEL7 systems that we need in our OS support matrix.

This reverts commit 74833b2.
We found issues when trying to build the project on RHEL7 systems that we need
in our OS support matrix.
@Fznamznon Fznamznon marked this pull request as ready for review December 14, 2022 10:23
@Fznamznon Fznamznon requested review from a team as code owners December 14, 2022 10:23
@Fznamznon
Copy link
Contributor Author

@intel/llvm-reviewers-runtime please review, it blocks pulldown process.

@Fznamznon
Copy link
Contributor Author

How to handle lint issue?

@steffenlarsen
Copy link
Contributor

How to handle lint issue?

Best option is probably just to address the formatting issues in an additional commit.

@steffenlarsen
Copy link
Contributor

CUDA failures are unrelated and have been reported. Since this is a NFC revert we will go ahead with the merge with missing review. @intel/dpcpp-esimd-reviewers for awareness.

@steffenlarsen steffenlarsen merged commit 84693b6 into intel:sycl Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants